From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754303AbdGJUPJ (ORCPT ); Mon, 10 Jul 2017 16:15:09 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:42547 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752158AbdGJUPI (ORCPT ); Mon, 10 Jul 2017 16:15:08 -0400 Date: Mon, 10 Jul 2017 22:15:03 +0200 From: Sebastian Reichel To: Linus Torvalds Cc: Thomas Gleixner , LKML , Andrew Morton , Ingo Molnar , "H. Peter Anvin" , Tony Lindgren , Pavel Machek Subject: Re: [GIT pull] irq updates for 4.13 Message-ID: <20170710201503.gsri545sz6enmovj@earth> References: <20170710133505.eo6w73kq2327n34p@earth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="t5nxnnttk2tzrstj" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --t5nxnnttk2tzrstj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Linus, On Mon, Jul 10, 2017 at 10:01:22AM -0700, Linus Torvalds wrote: > On Mon, Jul 10, 2017 at 6:35 AM, Sebastian Reichel > wrote: > > > > This patch apparently breaks OMAP platform: > > > > 46e48e257360f0845fe17089713cbad4db611e70 is the first bad commit > > commit 46e48e257360f0845fe17089713cbad4db611e70 > > Author: Thomas Gleixner > > Date: Thu Jun 29 23:33:38 2017 +0200 > > > > genirq: Move irq resource handling out of spinlocked region > > > > Boot failure log from Droid 4: > > [ ... snip snip ..] > > > > Droid 4 boots current master again after applying the patch below > > (which is git revet of above patch, but I provide the patch, since > > it did not revet cleanly). >=20 > Hmm. Do you actually need the full revert? It's technically not a full revert - I actually did not revert the __free_irq changes. > I think it's only the __setup_irq() part that looks like it may be garbag= e. >=20 > For example, I think it releases the resources twice if the > __irq_set_trigger() call fails. >=20 > But it looks questionably in other ways too - notably, the change to > make the request call be in the same context as the freeing is done is > apparently done entirely for symmetry reasons, not for any actual > *reason* reasons. >=20 > So I suspect just the __setup_irq() parts should be reverted, because > they look both buggy and pointless. But the actual *real* part of the > patch was the two-liner __free_irq() part, and that looks sane to me. >=20 > So Sebastian, can you test if it's ok to revert just the __setup_irq() > part, but leave the smaller part in __free_irq() that just moves the > irq_release_resources() around at freeing time? Looking at my patch it implements what you describe (by coincidence, since git revert could not do a clean revert) as far as I can see. It seems Pavel also understood it this way, since his patch is identical=20 to the one I provided. -- Sebastian --t5nxnnttk2tzrstj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAllj4EEACgkQ2O7X88g7 +pqJLg/+KXMKAlAsPYg8Ff3FUvAjwIazapyD85SIZdfE7SFgmeOiVaRy+XjMfYFE VYxHgq7kNRTgQqp9YlYMG/FvjFBTtSBmwOaYdg+Vdi2I4orJMWuQ5XIM3ZTvNSM5 77HGKR/ZJ4FB7izNB88fJ9fZP6YScWXze/Qgq1b4GXIlFaVw8W90dPc/PTHL0lO4 8ni1OOwUwS049aQwZpgWNEfDHLLAxrKDsuGu0H4TubSbQiZfOBaTkhE/y6NcEOrA 9ULB4uI3uAiurftvOiPwVTA27NoHL0sMpRdxEMK9JpU3cqGex/iPM2/iKPi6NJNy ENP5E+n7XDhbCYvgr4AR4dwlNnUUVTrLMTFfpB5iazM9Bp9MO8xZ8GFijBhoWxmA B2IlT+i5xPqhH/biRLQ6x68RL84FZWBtkaBRa0BPIclhHPwvVcIsclOEMJPfPuSH TU39gjjzKrxLRKKmc+tv5vZxWVBQYA36inUJBJgP4UyklGML0cVGHI+j15YqQfTz 7IXADd/0f4CofEzAdrjnhmxbQvd8NQ9zOb84gW/2NwTXfy5KxiWLAZ3b+s+WJF9/ cQsP+cnIUtJvLOwjvUlLJGmD2JvE8FGss48WjokszUNNb8asJMjMm7HRs08mf8+f TxbthcVFgGo3dest8sP5vENKCCXNSVnveo6RSLBoxNRhxpO0M0A= =H46W -----END PGP SIGNATURE----- --t5nxnnttk2tzrstj--