From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755636AbdGKMU2 (ORCPT ); Tue, 11 Jul 2017 08:20:28 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:36914 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755413AbdGKMU0 (ORCPT ); Tue, 11 Jul 2017 08:20:26 -0400 Date: Tue, 11 Jul 2017 14:20:23 +0200 From: Greg KH To: karuna grewal Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Subject: Re: [PATCH] staging: bcm2835-audio: replace BUG_ON with WARN_ON Message-ID: <20170711122023.GB21677@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 11, 2017 at 04:54:24PM +0530, karuna grewal wrote: > replace BUG_ON with WARN_ON as pointed out by checkpatch > > Signed-off-by: Karuna Grewal I can not accept patches sent in html format... > --- >  drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c b/ > drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c > index 5ff4b1c..30d310b 100644 > --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c > +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c > @@ -93,7 +93,7 @@ static int snd_bcm2835_ctl_get(struct snd_kcontrol *kcontrol, >         if (mutex_lock_interruptible(&chip->audio_mutex)) >                 return -EINTR; > > -       BUG_ON(!chip && !(chip->avail_substreams & AVAIL_SUBSTREAMS_MASK)); > +       WARN_ON(!chip && !(chip->avail_substreams & AVAIL_SUBSTREAMS_MASK)); Why will this make things better? thanks, greg k-h