From: Andi Kleen <ak@linux.intel.com>
To: kan.liang@intel.com
Cc: peterz@infradead.org, mingo@redhat.com,
linux-kernel@vger.kernel.org, jolsa@redhat.com, acme@kernel.org,
eranian@google.com
Subject: Re: [PATCH V3] perf/x86/intel/uncore: remove nonexistent clockticks event for client uncore
Date: Tue, 11 Jul 2017 08:24:49 -0700 [thread overview]
Message-ID: <20170711152449.GB3441@tassilo.jf.intel.com> (raw)
In-Reply-To: <20170711143346.2396-1-kan.liang@intel.com>
> User observable change with the patch.
> clockticks event is removed from CBOX. User may need to change their
> script to use uncore_clock/clockticks/ instead.
I don't think we can do that and break everyone's scripts. Have to keep
the old behavior, even though it is not ideal.
Or you fix the the uncore subsystem to support a separate attribute
array for the first cbox.
-Andi
next prev parent reply other threads:[~2017-07-11 15:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 14:33 kan.liang
2017-07-11 15:24 ` Andi Kleen [this message]
2017-07-11 15:43 ` Liang, Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170711152449.GB3441@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=acme@kernel.org \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®