From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933745AbdGKQO6 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 11 Jul 2017 12:14:58 -0400
Received: from bhuna.collabora.co.uk ([46.235.227.227]:44761 "EHLO
        bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932758AbdGKQO5 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 11 Jul 2017 12:14:57 -0400
Date: Tue, 11 Jul 2017 18:14:48 +0200
From: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, Tony Lindgren <tony@atomide.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
        Pavel Machek <pavel@ucw.cz>, Linus Walleij <linus.walleij@linaro.org>,
        Grygorii Strashko <grygorii.strashko@ti.com>
Subject: Re: [GIT pull] irq updates for 4.13
Message-ID: <20170711161448.yqrhymmejxtnx7e7@earth>
References: <alpine.DEB.2.20.1707091044210.2493@nanos>
 <20170710133505.eo6w73kq2327n34p@earth>
 <CA+55aFz5=ubNvhTUTzk3kFuLMFToP7xh7h8NDXDor9w+cjsCBA@mail.gmail.com>
 <alpine.DEB.2.20.1707110815440.1799@nanos>
 <alpine.DEB.2.20.1707110933590.1799@nanos>
 <20170711135131.GW3730@atomide.com>
 <alpine.DEB.2.20.1707111636180.1799@nanos>
 <CA+55aFwDgG6tZeqX7QPwxvwK8MMn_+RSkOgfG_jxzKkzySV6vw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="42d6jfskfewgzfh5"
Content-Disposition: inline
In-Reply-To: <CA+55aFwDgG6tZeqX7QPwxvwK8MMn_+RSkOgfG_jxzKkzySV6vw@mail.gmail.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--42d6jfskfewgzfh5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, Jul 11, 2017 at 08:40:10AM -0700, Linus Torvalds wrote:
> On Tue, Jul 11, 2017 at 7:41 AM, Thomas Gleixner <tglx@linutronix.de> wro=
te:
> >
> > Ah. Now that makes sense.
> >
> > Unpatched the ordering is:
> >
> >           chip_bus_lock(desc);
> >           irq_request_resources(desc);
>=20
> I *looked* at that ordering and then went "Naah, that makes no sense".
>=20
> But if that's the only issue, how about we just re-order those things
> - we still don't need to move the irq_request_resources() into the
> spinlock, we just move it to below the chip_bus_lock().
>=20
> IOW, something like the (COMPLETELY UNTEESTED!) attached patch.

That patch on top of 9967468c0a10 fixes boot on Droid 4.

> This assumes that the chip_bus_lock() thing is still ok for the RT
> case, but it looks like it might be: the only other one I looked at
> (apart from the gpio-omap one) used a mutex.

-- Sebastian

--42d6jfskfewgzfh5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAllk+XYACgkQ2O7X88g7
+pqrSg/8Cts154wUcM8odeCmLqYxiobk341A7iaaflitgB9qYhbO8XleB41zW2u4
UoKfLK8wlDPSQq6shqhH86oSNmQdNmSUCLVRr3SrBWpbahB8zNZNlWbsAHRnOTjO
+NwFrPEJic9IwHtbe/DBRWtKVsD/V8umc7NpTeSLfF+sOTlKUitgIkejasHT5P0V
pmPVhCbUbVuquhBgdvNW/BwZGe/4aUJCqqaa2QQSsThCRkjkFmCuO/eO4LqDGBhu
lzbHhaF8IGW/SMB5AuUGkB+N9rI3eKMIuGoXKVYdbXySeKxgomCmCWQIWnSPSJCq
b5hKnPIrNKZDRf5rkLfCHH+T4GLfAl9yE4oHnTW4M/JzUKBZTzsUOEXkNHr/MKRv
I2b5n/ttViAs4eyOIxyxGEYnRXQv82nE0V5EZnG6m5Rjw5PBSHLB+dyH4OdGA6Cx
M9eupN/zm6xO6HlzC8ehK6wMF2aN2jrMjILQNMOqZyJgNDWZyflLBOTjXuDMsJ7N
eJK033BbMlNP3jCVkEIHxDmC0wFGlfsoLzomnGJzbMD/nk6iiCHhJHKm25bNUv/F
q8wHkw2HxsBZuSbPZTBFFLiWkCeb70ntkioBcJVY/h2MwF3TmCwnqjOxFtN4yVd5
YTYz4EfRlnwp1K02LhnKYFVYwVmLl+yavBVrXiZpjyMm8mUZdeE=
=NdXX
-----END PGP SIGNATURE-----

--42d6jfskfewgzfh5--