From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756592AbdGKTEt (ORCPT ); Tue, 11 Jul 2017 15:04:49 -0400 Received: from iodev.co.uk ([82.211.30.53]:46564 "EHLO iodev.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755549AbdGKTEs (ORCPT ); Tue, 11 Jul 2017 15:04:48 -0400 X-Greylist: delayed 458 seconds by postgrey-1.27 at vger.kernel.org; Tue, 11 Jul 2017 15:04:47 EDT Date: Tue, 11 Jul 2017 15:56:58 -0300 From: Ismael Luceno To: Colin King Cc: Bluecherry Maintainers , Anton Sviridenko , Andrey Utkin , Mauro Carvalho Chehab , linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [media] solo6x10: make const array saa7128_regs_ntsc static Message-ID: <20170711185657.GC11785@pirotess.bf.iodev.co.uk> References: <20170710185103.18461-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170710185103.18461-1-colin.king@canonical.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/Jul/2017 19:51, Colin King wrote: > From: Colin Ian King > > Don't populate const array saa7128_regs_ntsc on the stack but insteaed make > it static. Makes the object code smaller and saves nearly 840 bytes > > Before: > text data bss dec hex filename > 9218 360 0 9578 256a solo6x10-tw28.o > > After: > text data bss dec hex filename > 8237 504 0 8741 2225 solo6x10-tw28.o > > Signed-off-by: Colin Ian King > --- > drivers/media/pci/solo6x10/solo6x10-tw28.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/pci/solo6x10/solo6x10-tw28.c b/drivers/media/pci/solo6x10/solo6x10-tw28.c > index 0632d3f7c73c..1c013a03d851 100644 > --- a/drivers/media/pci/solo6x10/solo6x10-tw28.c > +++ b/drivers/media/pci/solo6x10/solo6x10-tw28.c > @@ -532,7 +532,7 @@ static void saa712x_write_regs(struct solo_dev *dev, const u8 *vals, > static void saa712x_setup(struct solo_dev *dev) > { > const int reg_start = 0x26; > - const u8 saa7128_regs_ntsc[] = { > + static const u8 saa7128_regs_ntsc[] = { > /* :0x26 */ > 0x0d, 0x00, > /* :0x28 */ Signed-off-by: Ismael Luceno