From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934135AbdGKTl2 (ORCPT ); Tue, 11 Jul 2017 15:41:28 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:49488 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752607AbdGKTl1 (ORCPT ); Tue, 11 Jul 2017 15:41:27 -0400 From: Colin King To: Boris Ostrovsky , Juergen Gross , xen-devel@lists.xenproject.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][xen-next] xen/pvcalls: fix null pointer reference on sock_release call Date: Tue, 11 Jul 2017 20:41:21 +0100 Message-Id: <20170711194121.24802-1-colin.king@canonical.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King Currently a sock_release on map->sock will result in a null pointer deference on map when map is null. Instead, the sock_relase sould be on sock and not map->sock. Detected by CoverityScan, CID#1450169 ("Dereference after null check") Fixes: b535e2b9b78a ("xen/pvcalls: implement connect command") Signed-off-by: Colin Ian King --- drivers/xen/pvcalls-back.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c index d6c4c4aecb41..01b690e1e555 100644 --- a/drivers/xen/pvcalls-back.c +++ b/drivers/xen/pvcalls-back.c @@ -424,7 +424,7 @@ static int pvcalls_back_connect(struct xenbus_device *dev, sock); if (!map) { ret = -EFAULT; - sock_release(map->sock); + sock_release(sock); } out: -- 2.11.0