From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754306AbdGLVh7 (ORCPT ); Wed, 12 Jul 2017 17:37:59 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:32834 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752363AbdGLVh6 (ORCPT ); Wed, 12 Jul 2017 17:37:58 -0400 Date: Wed, 12 Jul 2017 14:37:57 -0700 (PDT) Message-Id: <20170712.143757.39770380256592298.davem@davemloft.net> To: dave.hansen@linux.intel.com Cc: linux-kernel@vger.kernel.org, jeffrey.t.kirsher@intel.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org Subject: Re: [PATCH] igb: fix unused igb_deliver_wake_packet() warning when CONFIG_PM=n From: David Miller In-Reply-To: <20170712210925.4F647FAA@viggo.jf.intel.com> References: <20170712210925.4F647FAA@viggo.jf.intel.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 12 Jul 2017 14:37:57 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dave Hansen Date: Wed, 12 Jul 2017 14:09:25 -0700 > > From: Dave Hansen > > I'm seeing warnings on kernel configurations where CONFIG_PM is > disabled. It happens in 4.12, at least: > > drivers/ethernet/intel/igb/igb_main.c:7988:13: warning: 'igb_deliver_wake_packet' defined but not used [-Wunused-function] > > This is because igb_deliver_wake_packet() is defined outside of > the #ifdef", but is used only a single time within the #ifdef in > igb_resume(). Fix it by moving igb_deliver_wake_packet() next to > igb_resume() inside the #ifdef. > > The diff ends up looking a bit funky here. It *looks* like > igb_suspend() is getting moved, but that's an artifact of how > 'diff' sees the changes. > > Cc: Jeff Kirsher > Cc: intel-wired-lan@lists.osuosl.org > Cc: netdev@vger.kernel.org > Signed-off-by: Dave Hansen I'll let Jeff queue this up into his tree.