mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Stefan Berger <stefanb@linux.vnet.ibm.com>,
	"Serge E. Hallyn" <serge@hallyn.com>,
	containers@lists.linux-foundation.org, lkp@01.org,
	linux-kernel@vger.kernel.org, zohar@linux.vnet.ibm.com,
	tycho@docker.com, James.Bottomley@HansenPartnership.com,
	vgoyal@redhat.com, christian.brauner@mailbox.org,
	amir73il@gmail.com, linux-security-module@vger.kernel.org,
	casey@schaufler-ca.com
Subject: Re: [PATCH v2] xattr: Enable security.capability in user namespaces
Date: Thu, 13 Jul 2017 12:40:12 -0400	[thread overview]
Message-ID: <20170713164012.brj2flnkaaks2oci@thunk.org> (raw)
In-Reply-To: <87y3rscz9j.fsf@xmission.com>

On Thu, Jul 13, 2017 at 07:11:36AM -0500, Eric W. Biederman wrote:
> The concise summary:
> 
> Today we have the xattr security.capable that holds a set of
> capabilities that an application gains when executed.  AKA setuid root exec
> without actually being setuid root.
> 
> User namespaces have the concept of capabilities that are not global but
> are limited to their user namespace.  We do not currently have
> filesystem support for this concept.

So correct me if I am wrong; in general, there will only be one
variant of the form:

   security.foo@uid=15000

It's not like there will be:

   security.foo@uid=1000
   security.foo@uid=2000

Except.... if you have an Distribution root directory which is shared
by many containers, you would need to put the xattrs in the overlay
inodes.  Worse, each time you launch a new container, with a new
subuid allocation, you will have to iterate over all files with
capabilities and do a copy-up operations on the xattrs in overlayfs.
So that's actually a bit of a disaster.

So for distribution overlays, you will need to do things a different
way, which is to map the distro subdirectory so you know that the
capability with the global uid 0 should be used for the container
"root" uid, right?

So this hack of using security.foo@uid=1000 is *only* useful when the
subcontainer root wants to create the privileged executable.  You
still have to do things the other way.

So can we make perhaps the assertion that *either*:

   security.foo

exists, *or*

   security.foo@uid=BAR

exists, but never both?  And there BAR is exclusive to only one
instances?

Otherwise, I suspect that the architecture is going to turn around and
bite us in the *ss eventually, because someone will want to do
something crazy and the solution will not be scalable.

	  	    		      	   -Ted

  reply	other threads:[~2017-07-13 16:40 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-11 15:05 [PATCH v2] Enable namespaced file capabilities Stefan Berger
2017-07-11 15:05 ` [PATCH v2] xattr: Enable security.capability in user namespaces Stefan Berger
2017-07-11 17:12   ` Serge E. Hallyn
2017-07-12  0:15     ` Stefan Berger
2017-07-12  0:47       ` Serge E. Hallyn
2017-07-12  3:45   ` Serge E. Hallyn
2017-07-12 11:35     ` Stefan Berger
2017-07-12 17:32       ` Serge E. Hallyn
2017-07-12  7:59   ` James Morris
2017-07-12 13:25   ` Eric W. Biederman
2017-07-12 17:03     ` Serge E. Hallyn
2017-07-12 22:20       ` James Morris
2017-07-13  0:33         ` Eric W. Biederman
2017-07-13  1:01           ` Serge E. Hallyn
2017-07-12 23:13       ` Eric W. Biederman
2017-07-13  0:43         ` Serge E. Hallyn
2017-07-13  0:44         ` Stefan Berger
2017-07-13  1:15           ` Theodore Ts'o
2017-07-13  2:34             ` Serge E. Hallyn
2017-07-13 12:11             ` Eric W. Biederman
2017-07-13 16:40               ` Theodore Ts'o [this message]
2017-07-13 17:05                 ` Stefan Berger
2017-07-13 17:39                   ` Eric W. Biederman
2017-07-13 19:14                     ` Theodore Ts'o
2017-07-13 19:41                       ` Serge E. Hallyn
2017-07-13 21:17                     ` Serge E. Hallyn
2017-07-18  7:01                   ` James Morris
2017-07-18 12:12                     ` Stefan Berger
2017-07-18 13:26                       ` Eric W. Biederman
2017-07-18 23:13                         ` Serge E. Hallyn
2017-07-13 17:14                 ` Eric W. Biederman
2017-07-13 17:33                   ` Stefan Berger
2017-07-13 17:49                     ` Eric W. Biederman
2017-07-13 19:48                       ` Serge E. Hallyn
2017-07-13 21:12                         ` Eric W. Biederman
     [not found]                       ` <9a3010e5-ca2b-5e7a-656b-fcc14f7bec4e@linux.vnet.ibm.com>
2017-07-14  0:38                         ` Eric W. Biederman
2017-07-14 11:32                           ` Stefan Berger
2017-07-14 12:04                             ` Eric W. Biederman
2017-07-14 12:39                               ` Stefan Berger
2017-07-14 13:34                             ` Serge E. Hallyn
2017-07-14 15:22                               ` Stefan Berger
2017-07-14 17:35                                 ` Serge E. Hallyn
2017-07-14 18:17                                   ` Eric W. Biederman
2017-07-14 18:48                                   ` Mimi Zohar
2017-07-14 18:52                                     ` James Bottomley
2017-07-14 20:03                                       ` Mimi Zohar
2017-07-14 20:39                                         ` James Bottomley
2017-07-14 21:34                                           ` Theodore Ts'o
2017-07-14 23:22                                             ` Eric W. Biederman
2017-07-14 23:29                                           ` Mimi Zohar
2017-07-14 23:53                                           ` Eric W. Biederman
2017-07-14 19:29                                     ` Theodore Ts'o
2017-07-14 19:43                                       ` Mimi Zohar
     [not found]                                   ` <xagsmtp2.20170714182525.6604@vmsdvm4.vnet.ibm.com>
2017-07-14 19:26                                     ` Mimi Zohar
2017-07-15  0:02                                       ` Eric W. Biederman
     [not found]                                       ` <xagsmtp3.20170715001054.9173@uk1vsc.vnet.ibm.com>
2017-07-16 11:25                                         ` Mimi Zohar
2017-07-26  3:00                                       ` Serge E. Hallyn
2017-07-26 13:57                                         ` Mimi Zohar
2017-07-14 17:36                                 ` Eric W. Biederman
2017-07-14 19:22                                   ` Stefan Berger
2017-07-13 21:21                     ` Serge E. Hallyn
2017-07-13 21:13                 ` Serge E. Hallyn
2017-07-12 17:53   ` Vivek Goyal
2017-07-12 19:19     ` Stefan Berger
2017-07-14 23:41   ` Eric W. Biederman
2017-07-15 21:27     ` Stefan Berger
2017-07-17 18:58   ` Vivek Goyal
2017-07-17 20:50     ` Stefan Berger
2017-07-18 11:48       ` Vivek Goyal
2017-07-18 12:05         ` Stefan Berger
2017-07-18 12:30           ` Vivek Goyal
2017-07-18 12:36             ` Vivek Goyal
2017-07-18 13:29               ` Eric W. Biederman
2017-07-18 13:21             ` Stefan Berger
2017-07-18 14:57               ` Vivek Goyal
2017-07-18 16:11                 ` Stefan Berger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170713164012.brj2flnkaaks2oci@thunk.org \
    --to=tytso@mit.edu \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=amir73il@gmail.com \
    --cc=casey@schaufler-ca.com \
    --cc=christian.brauner@mailbox.org \
    --cc=containers@lists.linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=lkp@01.org \
    --cc=serge@hallyn.com \
    --cc=stefanb@linux.vnet.ibm.com \
    --cc=tycho@docker.com \
    --cc=vgoyal@redhat.com \
    --cc=zohar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome