From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932122AbdGNMLm (ORCPT ); Fri, 14 Jul 2017 08:11:42 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:61645 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753787AbdGNMLj (ORCPT ); Fri, 14 Jul 2017 08:11:39 -0400 From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Shrikrishna Khare , "VMware, Inc." Cc: Greg Kroah-Hartman , Linus Torvalds , Guenter Roeck , akpm@linux-foundation.org, netdev@vger.kernel.org, "David S . Miller" , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, x86@kernel.org, Arnd Bergmann Subject: [PATCH 12/22] vmxnet3: avoid format strint overflow warning Date: Fri, 14 Jul 2017 14:07:04 +0200 Message-Id: <20170714120720.906842-13-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170714120720.906842-1-arnd@arndb.de> References: <20170714120720.906842-1-arnd@arndb.de> X-Provags-ID: V03:K0:P2RaBenBKc4eTUfOsEZ4xqyJbEaYR3P5Vx8j3pSAdMLqJpaRwfC 7YuUUvIqkOXnmzHPFAcDhK3GwxTVwZetsLoWRW8Ko+twyNs+Yy/SPGWP3BFmqSxLLb2wzIz Y32QvDuCauxji8VfES/xpvLbkktfzxZpEhRBO8FXwG7ohUVAt8Me86BlAOjLEfBlag5NToq 2Snyjvpdh4eygbl3UFtZw== X-UI-Out-Filterresults: notjunk:1;V01:K0:clGIvw0dkoA=:JGIzyFf24d82hzneC2fnEQ F8tHoPJjdgrUJaHOKRlG4P1f0SduwBWmoAU6Kb6FbyF29pTfmL9RZxTisyamHupo70hW3ZI9F Wf6wY6uLmTUEMY+IRAmgh3Y06iRX7x1OYIsHRf0v5c/y9Ly1PSQC7rI9171dD1PKP0P3meCGK nIPRPEpMRqnFZ+zFZJrjWzINPr/CO7T76RLxL5GSIUrgQmSbTvX0MulXyMr9IQqWAdEDpGGo2 NJyK0fb3fGBSxxZunPedY8vnUWSLSi93lZEuQ9i3DGKtnGEq97YGLTffCj6DOtzvLWhiNDD9a yBcqB26yLjSA6VUEbMjQSKOhW1U/m5Y2lkdT/xK3utu1181azvQECr0y0JnFcRv0aOuBYR7Aa ZyUO9jDHiRfREEY3mwX8RptWgkmLmKTZCokaCbDP3VmLXCuHQvQQ9ju6pA6ys2qj5lt0c7CS8 dBdLd2cWiZeQ6u80LVylOfBMtmxWLuldfVEmnW0CCzSyhDASEg0UXVHWuf1z6nJNZhRZTdVU4 NaqG6D8WjivE/dmaQuBEOJW/FLzENA+Egkb7eTv7tmbPKpBrWaK1RMWUKViXW/+jZvvBPY0Hr u2uX/56V4WSdowf5Fn/g6WST8zf9atLGTrel36XfGD9RX+r5Lcw7VXn5TiQPH5UlHJF5xUEQ4 b5kZQ35cMNwWGg2BU2YGOi3mBFqRmt1Nm8YYU1ej7qQcN1GIIjxqMwE7iskW5B9UFFaVKvXm5 vZtacPa1CG/C6FkR2GwTc8TD3kJzB67WkoD3bA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org gcc-7 notices that "-event-%d" could be more than 11 characters long if we had larger 'vector' numbers: drivers/net/vmxnet3/vmxnet3_drv.c: In function 'vmxnet3_activate_dev': drivers/net/vmxnet3/vmxnet3_drv.c:2095:40: error: 'sprintf' may write a terminating nul past the end of the destination [-Werror=format-overflow=] sprintf(intr->event_msi_vector_name, "%s-event-%d", ^~~~~~~~~~~~~ drivers/net/vmxnet3/vmxnet3_drv.c:2095:3: note: 'sprintf' output between 9 and 33 bytes into a destination of size 32 The current code is safe, but making the string a little longer is harmless and lets gcc see that it's ok. Signed-off-by: Arnd Bergmann --- drivers/net/vmxnet3/vmxnet3_int.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vmxnet3/vmxnet3_int.h b/drivers/net/vmxnet3/vmxnet3_int.h index ba1c9f93592b..9c51b8be0038 100644 --- a/drivers/net/vmxnet3/vmxnet3_int.h +++ b/drivers/net/vmxnet3/vmxnet3_int.h @@ -311,7 +311,7 @@ struct vmxnet3_intr { u8 num_intrs; /* # of intr vectors */ u8 event_intr_idx; /* idx of the intr vector for event */ u8 mod_levels[VMXNET3_LINUX_MAX_MSIX_VECT]; /* moderation level */ - char event_msi_vector_name[IFNAMSIZ+11]; + char event_msi_vector_name[IFNAMSIZ+17]; #ifdef CONFIG_PCI_MSI struct msix_entry msix_entries[VMXNET3_LINUX_MAX_MSIX_VECT]; #endif -- 2.9.0