From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932179AbdGNMKJ (ORCPT ); Fri, 14 Jul 2017 08:10:09 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:63447 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753573AbdGNMKF (ORCPT ); Fri, 14 Jul 2017 08:10:05 -0400 From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Satish Kharat , Sesidhar Baddela , Karan Tilak Kumar , "James E.J. Bottomley" , "Martin K. Petersen" Cc: Greg Kroah-Hartman , Linus Torvalds , Guenter Roeck , akpm@linux-foundation.org, netdev@vger.kernel.org, "David S . Miller" , linux-scsi@vger.kernel.org, x86@kernel.org, Arnd Bergmann Subject: [PATCH 06/22] scsi: fnic: fix format string overflow warning Date: Fri, 14 Jul 2017 14:06:58 +0200 Message-Id: <20170714120720.906842-7-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170714120720.906842-1-arnd@arndb.de> References: <20170714120720.906842-1-arnd@arndb.de> X-Provags-ID: V03:K0:AUW5c3mSXTSMFJD3X7qOLGQOyqS5fTSIKfLFi0PJh7HSONdJ373 2VlhNiULcHTh6Z/U7DDv7EHeZLOJUyJ+UdT42R3Uh7FZCSiuXc3ef5B6xT9hy3y415H1DbO r0aXVxk1IDpB08IDdoIefmGfOLiAEm/hmsOGA2wlSkHltuzBj4BhY7HQWuOu4yRpmoKCx05 q1A7TEaaFFdlbgvD5ve2A== X-UI-Out-Filterresults: notjunk:1;V01:K0:vx6N5lFRUsU=:Ihl63tpDqES3qT4X6sb8Mb jK/CQwD7LB4ZQio1XKi4XAYYxU1ecXuKjK0XcDjINtM81pYCHnPUkeIEcjh8tWNMChNk2hm5K u9g+ehbhgecLRnKIbRs7rSmfZ9jv9HZYWu+mZ/BHOgkaBFhL0jKAE8SiH6JIi997PSkk+6Zng 33uB3jFgYQOZUG4qQbAP99M+DeskTuqUWMYUPt4+9ctUoFk1vhbu3CSrkdvyQmiKX2TVI/TAH rPKRVP10vPQ3O6xu4lhuj9wRbs6mGnngFzGBnnk2e2g2EGBRhHieJGx3BtWzMIh+2KBbcJuBK +LJmAtnFIoQQwjLZ4WpCWOo+VMmS+j8UlRNXzrrn58k0+DkONf3RdcME+98AKKg5ZfFZJPP+4 pDP32PMVPRb5va/+2j0fdr4RG7JtkOrbMIKfj7fkxDP0pi9UX+iNbwuHu2WwAZd8Y2Ca/DzMh 7f61klBJMxE7787but+dY4u+ldlU38hDFl5zB7R9Rg+q2jUZkBoZ8MY+Qr9Aalot/JgHNFkc4 r2zExX01+2qX3Gt4F4yoseQQfMJ3DdG7LOIZ4zs/yFOhaEozLVQOaoFBFMbj6jtEcm4jP0x1r JCgthbHrA81a/9b33HLmCayGGq+ZL7s1Eac167lBpQQLRiNEM+TAp0APRkoNYJmYrZIiN2Em+ dGlC0k0b4DwcMm/MHrw0kzIs1+zOnytsQ7w1EoEQOBNAMTdRPASMjOn/ueRrxCl/RLiRULoXS iM+hGv0AIUN4iy7yB4j64HrLIflBPlp/z4kTNA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The MSI interrupt name can require 11 bytes in addition to the device name, for a total of 23 bytes: drivers/scsi/fnic/fnic_isr.c: In function 'fnic_request_intr': drivers/scsi/fnic/fnic_isr.c:192:4: error: '-fcs-rq' directive writing 7 bytes into a region of size between 5 and 16 [-Werror=format-overflow=] "%.11s-fcs-rq", fnic->name); drivers/scsi/fnic/fnic_isr.c:206:3: note: 'sprintf' output between 12 and 23 bytes into a destination of size 16 sprintf(fnic->msix[FNIC_MSIX_ERR_NOTIFY].devname, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ "%.11s-err-notify", fnic->name); This extends the buffer to fit any possible value. Signed-off-by: Arnd Bergmann --- drivers/scsi/fnic/fnic.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/fnic/fnic.h b/drivers/scsi/fnic/fnic.h index 67aab965c0f4..d094ba59ed15 100644 --- a/drivers/scsi/fnic/fnic.h +++ b/drivers/scsi/fnic/fnic.h @@ -180,7 +180,7 @@ enum fnic_msix_intr_index { struct fnic_msix_entry { int requested; - char devname[IFNAMSIZ]; + char devname[IFNAMSIZ + 11]; irqreturn_t (*isr)(int, void *); void *devid; }; -- 2.9.0