From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Mike Galbraith <efault@gmx.de>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] debug: fix WARN_ON_ONCE() for modules
Date: Sat, 15 Jul 2017 08:26:34 -0500 [thread overview]
Message-ID: <20170715132634.w4ytbyidwpb5zzsp@treble> (raw)
In-Reply-To: <1500100197.27838.21.camel@gmx.de>
On Sat, Jul 15, 2017 at 08:29:57AM +0200, Mike Galbraith wrote:
> On Sat, 2017-07-15 at 00:10 -0500, Josh Poimboeuf wrote:
> >
> > The bug table was made writable for vmlinux, which relies on
> > vmlinux.lds.S and vmlinux.lds.h for laying out the sections. However,
> > it wasn't made writable for modules, which rely on the ELF section
> > header flags.
>
> It seems vmlinux sort of relies on your fix too. objdump did show
> vmlinux __bug_table as being READONLY, but that (lie) is now gone.
Yeah, those ELF bits are ignored by the kernel. It sets its own
protections during boot, e.g. mark_rodata_ro().
--
Josh
next prev parent reply other threads:[~2017-07-15 13:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-15 5:10 Josh Poimboeuf
2017-07-15 6:29 ` Mike Galbraith
2017-07-15 13:26 ` Josh Poimboeuf [this message]
2017-07-16 9:51 ` Masami Hiramatsu
2017-07-17 14:00 ` Peter Zijlstra
2017-07-20 11:42 ` [tip:core/urgent] debug: Fix " tip-bot for Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170715132634.w4ytbyidwpb5zzsp@treble \
--to=jpoimboe@redhat.com \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®