From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751265AbdGPFec (ORCPT <rfc822;w@1wt.eu>);
        Sun, 16 Jul 2017 01:34:32 -0400
Received: from mail-pg0-f42.google.com ([74.125.83.42]:34747 "EHLO
        mail-pg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751084AbdGPFea (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 16 Jul 2017 01:34:30 -0400
Date: Sat, 15 Jul 2017 22:34:29 -0700
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Richard Purdie <rpurdie@rpsys.net>,
        Jacek Anaszewski <jacek.anaszewski@gmail.com>,
        linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org,
        Fenglin Wu <fenglinw@codeaurora.org>
Subject: Re: [PATCH v2 0/3] Qualcomm Light Pulse Generator
Message-ID: <20170716053429.GR1618@tuxbook>
References: <20170714224520.467-1-bjorn.andersson@linaro.org>
 <20170715091032.GA26602@amd>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170715091032.GA26602@amd>
User-Agent: Mutt/1.8.3 (2017-05-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat 15 Jul 02:10 PDT 2017, Pavel Machek wrote:

> Hi!
> 
> > This series introduces a generic pattern interface in the LED class and a
> > driver for the Qualcomm Light Pulse Generator.
> > 
> > Bjorn Andersson (3):
> >   leds: core: Introduce generic pattern interface
> 
> This one should be last. Let me review that, it is important to get
> this one right.
> 
> >   leds: Add driver for Qualcomm LPG
> 
> >   DT: leds: Add Qualcomm Light Pulse Generator binding
> 
> This one should be first.
> 

Okay, no problems.

> And I guess I'd prefer the driver to go in first, before the generic
> pattern interface.
> 

The driver won't compile without the additions to the header file. Would
you like the rest of the driver to go in first, then the generic
interface and finally the pattern part of the driver?

Large portions of the driver doesn't make sense without the pattern
part, so I think I would prefer it to go in as one patch.

Please let me know and I'll update the series.

Regards,
Bjorn