From: David Miller <davem@davemloft.net>
To: arvind.yadav.cs@gmail.com
Cc: nicolas.ferre@microchip.com, kvalo@codeaurora.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 08/11] net: cadence: macb: constify pci_device_id.
Date: Mon, 17 Jul 2017 13:38:09 -0700 (PDT) [thread overview]
Message-ID: <20170717.133809.1388368429079194648.davem@davemloft.net> (raw)
In-Reply-To: <1500315112-3249-1-git-send-email-arvind.yadav.cs@gmail.com>
From: Arvind Yadav <arvind.yadav.cs@gmail.com>
Date: Mon, 17 Jul 2017 23:41:52 +0530
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 791 336 0 1127 467 net/ethernet/cadence/macb_pci.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 855 272 0 1127 467 net/ethernet/cadence/macb_pci.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Applied.
prev parent reply other threads:[~2017-07-17 20:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 18:11 Arvind Yadav
2017-07-17 20:38 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170717.133809.1388368429079194648.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arvind.yadav.cs@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®