From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751265AbdGQAQe (ORCPT ); Sun, 16 Jul 2017 20:16:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44206 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751124AbdGQAQd (ORCPT ); Sun, 16 Jul 2017 20:16:33 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 077D210D4E1 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=swood@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 077D210D4E1 From: Scott Wood To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Scott Wood Subject: [PATCH 1/8] ktest: Clarify config file usage Date: Sun, 16 Jul 2017 19:16:23 -0500 Message-Id: <20170717001630.10518-1-swood@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 17 Jul 2017 00:16:33 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Simply telling a new user to edit "the config file" without giving any hints on where that file should go, what it should be named, or where a template can be found, is not particularly helpful. Signed-off-by: Scott Wood --- tools/testing/ktest/ktest.pl | 3 ++- tools/testing/ktest/sample.conf | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl index 0c8b61f8398e..cdf6974bc462 100755 --- a/tools/testing/ktest/ktest.pl +++ b/tools/testing/ktest/ktest.pl @@ -1140,7 +1140,8 @@ sub __read_config { sub get_test_case { print "What test case would you like to run?\n"; print " (build, install or boot)\n"; - print " Other tests are available but require editing the config file\n"; + print " Other tests are available but require editing ktest.conf\n"; + print " (see tools/testing/ktest/sample.conf)\n"; my $ans = ; chomp $ans; $default{"TEST_TYPE"} = $ans; diff --git a/tools/testing/ktest/sample.conf b/tools/testing/ktest/sample.conf index 6c58cd8bbbae..7636236b87d3 100644 --- a/tools/testing/ktest/sample.conf +++ b/tools/testing/ktest/sample.conf @@ -1,6 +1,9 @@ # # Config file for ktest.pl # +# Place your customized version of this, named ktest.conf, in the +# working directory that ktest.pl is run from. +# # Note, all paths must be absolute # -- 2.9.4