From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751298AbdGQH7J (ORCPT ); Mon, 17 Jul 2017 03:59:09 -0400 Received: from mail-wr0-f169.google.com ([209.85.128.169]:34225 "EHLO mail-wr0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751257AbdGQH7H (ORCPT ); Mon, 17 Jul 2017 03:59:07 -0400 Date: Mon, 17 Jul 2017 08:59:04 +0100 From: Lee Jones To: Michal Simek Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu Subject: Re: [PATCH] mfd: Add missing Kconfig dependency for TPS65086 Message-ID: <20170717075904.crnbzf2i2zon3bby@dell> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 13 Jul 2017, Michal Simek wrote: > MTF_CORE should be enabled when driver is enabled. "MFD_CORE" You also need more information here. Why is it required? What happens if it's not specified? Etc. > Signed-off-by: Michal Simek > --- > > drivers/mfd/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 94ad2c1c3d90..f98b5a6d4da8 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -1294,6 +1294,7 @@ config TPS6507X > > config MFD_TPS65086 > tristate "TI TPS65086 Power Management Integrated Chips (PMICs)" > + select MFD_CORE > select REGMAP > select REGMAP_IRQ > select REGMAP_I2C -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog