From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751340AbdGQK7J (ORCPT ); Mon, 17 Jul 2017 06:59:09 -0400 Received: from mail-wr0-f170.google.com ([209.85.128.170]:36646 "EHLO mail-wr0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751280AbdGQK7H (ORCPT ); Mon, 17 Jul 2017 06:59:07 -0400 Date: Mon, 17 Jul 2017 11:59:04 +0100 From: Lee Jones To: Hans de Goede Cc: Jarkko Nikula , Len Brown , Andy Shevchenko , Mika Westerberg , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mfd: intel_soc_pmic: Differentiate between Bay and Cherry Trail CRC variants Message-ID: <20170717105904.iguqoroc5o74hj4f@dell> References: <20170701101346.13578-1-hdegoede@redhat.com> <20170701101346.13578-2-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170701101346.13578-2-hdegoede@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 01 Jul 2017, Hans de Goede wrote: > Both Bay and Cherry Trail devices may be used together with a Crystal Cove > PMIC. Each platform has its own variant of the PMIC, which both use the > same ACPI HID, but they are not 100% compatible. > > This commits makes the intel_soc_pmic_core code check the _HRV of the > ACPI-firmware-node and selects intel_soc_pmic_config_byt_crc resp. > intel_soc_pmic_config_cht_crc based on this. > > This fixes the Bay Trail specific ACPI OpRegion code causing problems > on Cherry Trail devices. Specifically this was causing the external > microsd slot on a Dell Venue 8 5855 (Cherry Trail version) to not work > and the eMMC to become unreliable and throw lots of errors. > > Reported-and-tested-by: russianneuromancer Real names only please. What is the name of this reporter/tester? > Signed-off-by: Hans de Goede > --- > drivers/mfd/Kconfig | 4 ++-- > drivers/mfd/intel_soc_pmic_core.c | 34 ++++++++++++++++++++++++++++------ > 2 files changed, 30 insertions(+), 8 deletions(-) Code looks okay though: For my own reference: Acked-for-MFD-by: Lee Jones -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog