From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751384AbdGQLBB (ORCPT ); Mon, 17 Jul 2017 07:01:01 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:35853 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751281AbdGQLBA (ORCPT ); Mon, 17 Jul 2017 07:01:00 -0400 Date: Mon, 17 Jul 2017 12:00:56 +0100 From: Lee Jones To: Julia Lawall Cc: keescook@chromium.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 9/9] mfd: max8925-i2c: Drop unnecessary static Message-ID: <20170717110056.q5fp3wvjoamov5c2@dell> References: <1493928654-18768-1-git-send-email-Julia.Lawall@lip6.fr> <1493928654-18768-10-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1493928654-18768-10-git-send-email-Julia.Lawall@lip6.fr> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 04 May 2017, Julia Lawall wrote: > Drop static on a local variable, when the variable is initialized before > any use, on every possible execution path through the function. The static > has no benefit, and dropping it reduces the code size. > > The semantic patch that fixes this problem is as follows: > (http://coccinelle.lip6.fr/) > > // > @bad exists@ > position p; > identifier x; > type T; > @@ > > static T x@p; > ... > x = <+...x...+> > > @@ > identifier x; > expression e; > type T; > position p != bad.p; > @@ > > -static > T x@p; > ... when != x > when strict > ?x = e; > // > > The change in code size is indicates by the following output from the size > command. > > before: > text data bss dec hex filename > 2579 240 16 2835 b13 drivers/mfd/max8925-i2c.o > > after: > text data bss dec hex filename > 2531 240 8 2779 adb drivers/mfd/max8925-i2c.o > > Signed-off-by: Julia Lawall > > --- > drivers/mfd/max8925-i2c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. > diff --git a/drivers/mfd/max8925-i2c.c b/drivers/mfd/max8925-i2c.c > index 5c80aea..1006323 100644 > --- a/drivers/mfd/max8925-i2c.c > +++ b/drivers/mfd/max8925-i2c.c > @@ -151,7 +151,7 @@ static int max8925_probe(struct i2c_client *client, > const struct i2c_device_id *id) > { > struct max8925_platform_data *pdata = dev_get_platdata(&client->dev); > - static struct max8925_chip *chip; > + struct max8925_chip *chip; > struct device_node *node = client->dev.of_node; > > if (node && !pdata) { > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog