From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751377AbdGQLEU (ORCPT ); Mon, 17 Jul 2017 07:04:20 -0400 Received: from mail-wr0-f175.google.com ([209.85.128.175]:34706 "EHLO mail-wr0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751286AbdGQLET (ORCPT ); Mon, 17 Jul 2017 07:04:19 -0400 Date: Mon, 17 Jul 2017 12:04:15 +0100 From: Lee Jones To: Hans de Goede Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: intel_soc_pmic_chtwc: Turn Kconfig option into a bool Message-ID: <20170717110415.ecavjnwcjwkd4a4b@dell> References: <20170623082940.24917-1-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170623082940.24917-1-hdegoede@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 23 Jun 2017, Hans de Goede wrote: > The PMIC provides ACPI OpRegions which must be available for other > drivers' PS0 / PS3 methods early-on as such it must be builtin as the > Kconfig help text already states. > > Somehow its Kconfig option ended up being a tristate though, this fixes > this. > > Signed-off-by: Hans de Goede > --- > Note, feel free to squash this in the original commit if you wish Looks like the original commit is yet to be accepted. Please ensure it's squashed in and resubmit. > --- > drivers/mfd/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 8533cb46a875..be962d128f31 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -476,7 +476,7 @@ config INTEL_SOC_PMIC_BXTWC > on these systems. > > config INTEL_SOC_PMIC_CHTWC > - tristate "Support for Intel Cherry Trail Whiskey Cove PMIC" > + bool "Support for Intel Cherry Trail Whiskey Cove PMIC" > depends on ACPI && HAS_IOMEM && I2C=y && COMMON_CLK > depends on X86 || COMPILE_TEST > select MFD_CORE -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog