From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751422AbdGQM0n (ORCPT ); Mon, 17 Jul 2017 08:26:43 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:45752 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751379AbdGQM0l (ORCPT ); Mon, 17 Jul 2017 08:26:41 -0400 Date: Mon, 17 Jul 2017 14:26:35 +0200 From: Greg KH To: AndyS Cc: eric@anholt.net, stefan.wahren@i2se.com, daniels@collabora.com, noralf@tronnes.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging:vc04_services:vchiq_util.c: kzalloc call changed to kcalloc Message-ID: <20170717122635.GB24503@kroah.com> References: <20170716163908.7260-1-lkd1024@mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170716163908.7260-1-lkd1024@mail.ru> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 16, 2017 at 07:39:08PM +0300, AndyS wrote: > From: Andrey Severin > > kzalloc call was changed to kcalloc by checkpatch.pl recommendation > > --- > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_util.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_util.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_util.c > index 7fa0310e7b9e..2e52f07bbaa9 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_util.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_util.c > @@ -51,7 +51,7 @@ int vchiu_queue_init(VCHIU_QUEUE_T *queue, int size) > sema_init(&queue->pop, 0); > sema_init(&queue->push, 0); > > - queue->storage = kzalloc(size * sizeof(VCHIQ_HEADER_T *), GFP_KERNEL); > + queue->storage = kcalloc(size, sizeof(VCHIQ_HEADER_T *), GFP_KERNEL); > if (!queue->storage) { > vchiu_queue_delete(queue); > return 0; > -- > 2.13.2 Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch does not have a Signed-off-by: line. Please read the kernel file, Documentation/SubmittingPatches and resend it after adding that line. Note, the line needs to be in the body of the email, before the patch, not at the bottom of the patch or in the email signature. - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change. - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot