From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751343AbdGQPvN (ORCPT ); Mon, 17 Jul 2017 11:51:13 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:36156 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751286AbdGQPvL (ORCPT ); Mon, 17 Jul 2017 11:51:11 -0400 From: Masami Ichikawa To: paul@paul-moore.com, eparis@redhat.com Cc: masami256@gmail.com, linux-audit@redhat.com, linux-kernel@vger.kernel.org Subject: [PATCH] Free skb at error context in auditd_send_unicast_skb(). Date: Tue, 18 Jul 2017 00:50:54 +0900 Message-Id: <20170717155054.31948-1-masami256@gmail.com> X-Mailer: git-send-email 2.13.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I got following memory leak reports by kmemleak. unreferenced object 0xffff965962fa0600 (size 256): comm "auditd", pid 401, jiffies 4294671604 (age 62.331s) hex dump (first 32 bytes): 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ backtrace: [] kmemleak_alloc+0x4a/0xa0 [] kmem_cache_alloc_node+0x146/0x1f0 [] __alloc_skb+0x5b/0x1e0 [] audit_make_reply+0x5c/0xd0 [] audit_receive_msg+0xa1a/0xe60 [] audit_receive+0x53/0xa0 [] netlink_unicast+0x18b/0x220 [] netlink_sendmsg+0x2c5/0x3c0 [] sock_sendmsg+0x38/0x50 [] SYSC_sendto+0x13f/0x180 [] SyS_sendto+0xe/0x10 [] do_syscall_64+0x67/0x140 [] return_from_SYSCALL_64+0x0/0x6a [] 0xffffffffffffffff unreferenced object 0xffff96595a9da600 (size 512): comm "auditd", pid 401, jiffies 4294671604 (age 62.331s) hex dump (first 32 bytes): 14 00 00 00 31 05 00 00 00 00 00 00 00 00 00 00 ....1........... 91 01 00 00 01 00 00 00 00 00 00 00 00 00 00 00 ................ backtrace: [] kmemleak_alloc+0x4a/0xa0 [] __kmalloc_node_track_caller+0x233/0x2f0 [] __kmalloc_reserve.isra.38+0x31/0x90 [] __alloc_skb+0x87/0x1e0 [] audit_make_reply+0x5c/0xd0 [] audit_receive_msg+0xa1a/0xe60 [] audit_receive+0x53/0xa0 [] netlink_unicast+0x18b/0x220 [] netlink_sendmsg+0x2c5/0x3c0 [] sock_sendmsg+0x38/0x50 [] SYSC_sendto+0x13f/0x180 [] SyS_sendto+0xe/0x10 [] do_syscall_64+0x67/0x140 [] return_from_SYSCALL_64+0x0/0x6a [] 0xffffffffffffffff These skb objects have been allocated in audit_replace(). If some error happened in auditd_send_unicast_skb(), skb is needed to be freed. Signed-off-by: Masami Ichikawa --- kernel/audit.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/audit.c b/kernel/audit.c index 833267bbd80b..789f4cc1f481 100644 --- a/kernel/audit.c +++ b/kernel/audit.c @@ -659,6 +659,7 @@ static int auditd_send_unicast_skb(struct sk_buff *skb) err: if (ac && rc == -ECONNREFUSED) auditd_reset(ac); + kfree_skb(skb); return rc; } -- 2.13.0