From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751472AbdGQQEi (ORCPT ); Mon, 17 Jul 2017 12:04:38 -0400 Received: from mx2.suse.de ([195.135.220.15]:49101 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751284AbdGQQEh (ORCPT ); Mon, 17 Jul 2017 12:04:37 -0400 Date: Mon, 17 Jul 2017 18:04:33 +0200 From: "Luis R. Rodriguez" To: Greg KH Cc: "Luis R. Rodriguez" , wagi@monom.org, yi1.li@linux.intel.com, takahiro.akashi@linaro.org, luto@kernel.org, ebiederm@xmission.com, dmitry.torokhov@gmail.com, arend.vanspriel@broadcom.com, dwmw2@infradead.org, rjw@rjwysocki.net, atull@kernel.org, moritz.fischer@ettus.com, pmladek@suse.com, johannes.berg@intel.com, emmanuel.grumbach@intel.com, luciano.coelho@intel.com, kvalo@codeaurora.org, torvalds@linux-foundation.org, keescook@chromium.org, dhowells@redhat.com, pjones@redhat.com, hdegoede@redhat.com, alan@linux.intel.com, tytso@mit.edu, dave@stgolabs.net, mawilcox@microsoft.com, tglx@linutronix.de, peterz@infradead.org, mfuzzey@parkeon.com, jakub.kicinski@netronome.com, nbroeking@me.com, jewalt@lgsinnovations.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/4] firmware: send -EINTR on signal abort on fallback mechanism Message-ID: <20170717160433.GI21846@wotan.suse.de> References: <20170629205151.5329-1-mcgrof@kernel.org> <20170629205151.5329-5-mcgrof@kernel.org> <20170717140007.GA12884@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170717140007.GA12884@kroah.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 17, 2017 at 04:00:07PM +0200, Greg KH wrote: > On Thu, Jun 29, 2017 at 01:51:51PM -0700, Luis R. Rodriguez wrote: > > Right now we send -EAGAIN to a syfs write which got interrupted. > > Userspace can't tell what happened though, send -EINTR if we > > were killed due to a signal so userspace can tell things apart. > > > > This is only applicable to the fallback mechanism. > > > > Reported-by: Martin Fuzzey > > Signed-off-by: Luis R. Rodriguez > > --- > > drivers/base/firmware_class.c | 9 ++++++--- > > 1 file changed, 6 insertions(+), 3 deletions(-) > > This doesn't need to go into 4.13-final, right? Nope. > Can it wait for 4.14-rc1? Yes. The bigger issue was the unexpected signals causing interruption. This I consider a secondary and not critical issue so I did not Cc stable. Luis