From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751490AbdGQQ2p (ORCPT ); Mon, 17 Jul 2017 12:28:45 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:50448 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751291AbdGQQ2n (ORCPT ); Mon, 17 Jul 2017 12:28:43 -0400 Date: Mon, 17 Jul 2017 18:28:38 +0200 From: Greg KH To: Jiri Pirko Cc: linux-kernel@vger.kernel.org, davem@davemloft.net, mchehab@kernel.org, jikos@kernel.org Subject: Re: [patch 0/2] add actuators support Message-ID: <20170717162838.GF9786@kroah.com> References: <20170717161914.5043-1-jiri@resnulli.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170717161914.5043-1-jiri@resnulli.us> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 17, 2017 at 06:19:12PM +0200, Jiri Pirko wrote: > From: Jiri Pirko > > I am owner of height adjustable desk and naturally, as it has an USB > interface, I need to controll it from my computer. Started to think > about what would be the best way, I realized that I need to introduce > a new driver class in kernel. The reason is a need to have one API > for all possible kinds of actuator devices (USB, I2C, gpio, etc). Why does this have to be a kernel driver at all? Your USB driver should really just be a simple userspace application (use libusb to have it work on all operating systems.) While the idea of a "generic class" is nice, given that there is only one device of this type out there so far, and it's a USB one, kind of implies that a generic class isn't needed just yet. Oh, and it's nice to cc: the linux-usb@vger mailing list for USB patches in the future :) thanks, greg k-h