From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <chao@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Eric Biggers <ebiggers@google.com>
Subject: Re: [f2fs-dev] [PATCH] f2fs: include seq_file.h for sysfs.c
Date: Mon, 17 Jul 2017 09:55:04 -0700 [thread overview]
Message-ID: <20170717165504.GA81128@jaegeuk-macbookpro.roam.corp.google.com> (raw)
In-Reply-To: <8fe6971d-a71b-7641-de71-cd68adff2b74@kernel.org>
On 07/17, Chao Yu wrote:
> Hi Jaegeuk,
>
> On 2017/7/14 9:01, Jaegeuk Kim wrote:
> > This patch includes seq_file.h to avoid compile error.
>
> I didn't hit the error, I guess that's because we have included f2fs_fs.h
> in sysfs.c, the inclusion relation is like this:
> - sysfs.c
> - f2fs_fs.h
> - pagemap.h
> - fs.h
> - struct seq_file
What about seq ops such as seq_puts?
Thanks,
>
> Thanks,
>
> >
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
> > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> > ---
> > fs/f2fs/sysfs.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
> > index 9adc202fcd6f..71191d89917d 100644
> > --- a/fs/f2fs/sysfs.c
> > +++ b/fs/f2fs/sysfs.c
> > @@ -11,6 +11,7 @@
> > */
> > #include <linux/proc_fs.h>
> > #include <linux/f2fs_fs.h>
> > +#include <linux/seq_file.h>
> >
> > #include "f2fs.h"
> > #include "segment.h"
> >
next prev parent reply other threads:[~2017-07-17 16:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-14 1:01 Jaegeuk Kim
2017-07-17 14:25 ` [f2fs-dev] " Chao Yu
2017-07-17 16:55 ` Jaegeuk Kim [this message]
2017-07-18 1:23 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170717165504.GA81128@jaegeuk-macbookpro.roam.corp.google.com \
--to=jaegeuk@kernel.org \
--cc=chao@kernel.org \
--cc=ebiggers@google.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®