From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751415AbdGQT7c (ORCPT ); Mon, 17 Jul 2017 15:59:32 -0400 Received: from mail-pg0-f54.google.com ([74.125.83.54]:34860 "EHLO mail-pg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751317AbdGQT7a (ORCPT ); Mon, 17 Jul 2017 15:59:30 -0400 From: Matthias Kaehlcke To: Daniel Vetter , Jani Nikula , David Airlie , Daniel Vetter , Manasi Navare , rodrigo.vivi@intel.com, clinton.a.taylor@intel.com Cc: intel-gfx , dri-devel@lists.freedesktop.org, Linux Kernel Mailing List , =?UTF-8?q?St=C3=A9phane=20Marchesin?= , Grant Grundler , Matthias Kaehlcke Subject: [PATCH v2] drm/i915: Return correct EDP voltage swing table for 0.85V Date: Mon, 17 Jul 2017 12:58:54 -0700 Message-Id: <20170717195854.192139-1-mka@chromium.org> X-Mailer: git-send-email 2.13.2.932.g7449e964c-goog Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org For 0.85V cnl_get_buf_trans_edp() returns the DP table, instead of EDP. Use the correct table. The error was pointed out by this clang warning: drivers/gpu/drm/i915/intel_ddi.c:392:39: warning: variable 'cnl_ddi_translations_edp_0_85V' is not needed and will not be emitted [-Wunneeded-internal-declaration] static const struct cnl_ddi_buf_trans cnl_ddi_translations_edp_0_85V[] = { Fixes: cf54ca8bc567 ("drm/i915/cnl: Implement voltage swing sequence.") Signed-off-by: Matthias Kaehlcke Reviewed-by: Manasi Navare --- Changes in v2: - Added 'Fixes' tag - Added Reviewed-by: Manasi Navare drivers/gpu/drm/i915/intel_ddi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c index efb13582dc73..6fa02e6a7a9b 100644 --- a/drivers/gpu/drm/i915/intel_ddi.c +++ b/drivers/gpu/drm/i915/intel_ddi.c @@ -1873,7 +1873,7 @@ cnl_get_buf_trans_edp(struct drm_i915_private *dev_priv, if (dev_priv->vbt.edp.low_vswing) { if (voltage == VOLTAGE_INFO_0_85V) { *n_entries = ARRAY_SIZE(cnl_ddi_translations_edp_0_85V); - return cnl_ddi_translations_dp_0_85V; + return cnl_ddi_translations_edp_0_85V; } else if (voltage == VOLTAGE_INFO_0_95V) { *n_entries = ARRAY_SIZE(cnl_ddi_translations_edp_0_95V); return cnl_ddi_translations_edp_0_95V; -- 2.13.2.932.g7449e964c-goog