From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751490AbdGQWjB (ORCPT ); Mon, 17 Jul 2017 18:39:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:33586 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751341AbdGQWi7 (ORCPT ); Mon, 17 Jul 2017 18:38:59 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4409122BDF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jaegeuk@kernel.org Date: Mon, 17 Jul 2017 15:38:58 -0700 From: Jaegeuk Kim To: Chao Yu Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH v2] f2fs: avoid cpu lockup Message-ID: <20170717223858.GD81128@jaegeuk-macbookpro.roam.corp.google.com> References: <20170715012245.24640-1-jaegeuk@kernel.org> <20170716010422.GA51202@jaegeuk-macbookpro.roam.corp.google.com> <330acf45-f218-cb85-28b6-08e12c4fb888@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <330acf45-f218-cb85-28b6-08e12c4fb888@kernel.org> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/17, Chao Yu wrote: > On 2017/7/16 9:04, Jaegeuk Kim wrote: > > Before retrying to flush data or dentry pages, we need to release cpu in order > > to prevent watchdog. > > > > Signed-off-by: Jaegeuk Kim > > Reviewed-by: Chao Yu > > > --- > > Change log from v1: > > - timeout more specifically > > > > fs/f2fs/checkpoint.c | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c > > index 56bbf592e487..5b876f6d3f6b 100644 > > --- a/fs/f2fs/checkpoint.c > > +++ b/fs/f2fs/checkpoint.c > > @@ -879,6 +879,7 @@ int sync_dirty_inodes(struct f2fs_sb_info *sbi, enum inode_type type) > > struct inode *inode; > > struct f2fs_inode_info *fi; > > bool is_dir = (type == DIR_INODE); > > + unsigned long ino = 0; > > > > trace_f2fs_sync_dirty_inodes_enter(sbi->sb, is_dir, > > get_pages(sbi, is_dir ? > > @@ -901,8 +902,17 @@ int sync_dirty_inodes(struct f2fs_sb_info *sbi, enum inode_type type) > > inode = igrab(&fi->vfs_inode); > > spin_unlock(&sbi->inode_lock[type]); > > if (inode) { > > + unsigned long cur_ino = inode->i_ino; > > + > > filemap_fdatawrite(inode->i_mapping); > > iput(inode); > > + /* We need to give cpu to another writers. */ > > + if (ino == cur_ino) { > > We failed to flush dirty pages of inode due to encountering -EAGAIN of writepage? Actually, I found this from a bug case in experimental patches which just skips it accidently. I think WB_SYNC_ALL doesn't return EAGAIN. Thanks, > > Thanks, > > > + congestion_wait(BLK_RW_ASYNC, HZ/50); > > + cond_resched(); > > + } else { > > + ino = cur_ino; > > + } > > } else { > > /* > > * We should submit bio, since it exists several > >