mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: david.kershner@unisys.com, Timothy.Sell@unisys.com,
	bryan.thompson@unisys.com, jon.frisch@unisys.com,
	david.binder@unisys.com, sparmaintainer@unisys.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: unisys: visorbus: Constify attribute_group structures.
Date: Tue, 18 Jul 2017 08:50:35 +0200	[thread overview]
Message-ID: <20170718065034.GA29567@kroah.com> (raw)
In-Reply-To: <5640372c21153b23cf335197af02feb86cce30ac.1500355038.git.arvind.yadav.cs@gmail.com>

On Tue, Jul 18, 2017 at 10:54:21AM +0530, Arvind Yadav wrote:
> attribute_group are not supposed to change at runtime. All functions
> working with attribute_group provided by <linux/sysfs.h> work
> with const attribute_group. So mark the non-const structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> Changes in v2:
>               Change log typo was not correct.
> 
>  drivers/staging/unisys/visorbus/visorbus_main.c | 4 ++--
>  drivers/staging/unisys/visorbus/visorchipset.c  | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)

Does not apply to my tree at all anymore, probably due to other visorbus
patches I just took :(

Please rebase and resend.

thanks,

greg k-h

      reply	other threads:[~2017-07-18  6:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-18  5:24 Arvind Yadav
2017-07-18  6:50 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170718065034.GA29567@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Timothy.Sell@unisys.com \
    --cc=arvind.yadav.cs@gmail.com \
    --cc=bryan.thompson@unisys.com \
    --cc=david.binder@unisys.com \
    --cc=david.kershner@unisys.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=jon.frisch@unisys.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sparmaintainer@unisys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome