From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751403AbdGRHRa (ORCPT ); Tue, 18 Jul 2017 03:17:30 -0400 Received: from mail-wr0-f177.google.com ([209.85.128.177]:36462 "EHLO mail-wr0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751026AbdGRHR3 (ORCPT ); Tue, 18 Jul 2017 03:17:29 -0400 Date: Tue, 18 Jul 2017 08:17:25 +0100 From: Lee Jones To: Andy Shevchenko Cc: Hans de Goede , Jarkko Nikula , Len Brown , Mika Westerberg , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mfd: intel_soc_pmic: Differentiate between Bay and Cherry Trail CRC variants Message-ID: <20170718071725.irultqetstthnozh@dell> References: <20170701101346.13578-1-hdegoede@redhat.com> <20170701101346.13578-2-hdegoede@redhat.com> <20170717105904.iguqoroc5o74hj4f@dell> <1500297783.29303.42.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1500297783.29303.42.camel@linux.intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 17 Jul 2017, Andy Shevchenko wrote: > On Mon, 2017-07-17 at 11:59 +0100, Lee Jones wrote: > > On Sat, 01 Jul 2017, Hans de Goede wrote: > > > > > Both Bay and Cherry Trail devices may be used together with a > > > Crystal Cove > > > PMIC. Each platform has its own variant of the PMIC, which both use > > > the > > > same ACPI HID, but they are not 100% compatible. > > > > > > This commits makes the intel_soc_pmic_core code check the _HRV of > > > the > > > ACPI-firmware-node and selects intel_soc_pmic_config_byt_crc resp. > > > intel_soc_pmic_config_cht_crc based on this. > > > > > > This fixes the Bay Trail specific ACPI OpRegion code causing > > > problems > > > on Cherry Trail devices. Specifically this was causing the external > > > microsd slot on a Dell Venue 8 5855 (Cherry Trail version) to not > > > work > > > and the eMMC to become unreliable and throw lots of errors. > > > > > > Reported-and-tested-by: russianneuromancer > > > > > > > Real names only please. > > > > What is the name of this reporter/tester? > > No one knows, I think. Then I don't think we can credit him/her for their efforts. SubmittingPatches clearly states "no pseudonyms or anonymous contributions". Either write to them and ask for their real name so that they can be credited, or remove the line. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog