From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751450AbdGRJIM (ORCPT ); Tue, 18 Jul 2017 05:08:12 -0400 Received: from mail-wr0-f177.google.com ([209.85.128.177]:36119 "EHLO mail-wr0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751428AbdGRJIL (ORCPT ); Tue, 18 Jul 2017 05:08:11 -0400 Date: Tue, 18 Jul 2017 10:08:07 +0100 From: Lee Jones To: Michal Simek Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu Subject: Re: [PATCH v2] mfd: Add missing Kconfig dependency for TPS65086 Message-ID: <20170718090807.nrqi7okqq2hxiy7s@dell> References: <3dd9281f07c0d216434cb158d11d3ccf58bf0802.1500283733.git.michal.simek@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3dd9281f07c0d216434cb158d11d3ccf58bf0802.1500283733.git.michal.simek@xilinx.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 17 Jul 2017, Michal Simek wrote: > MTF_CORE should be enabled when driver is enabled. > > Without this patch you can configure: > CONFIG_MFD_CORE is not set > CONFIG_MFD_TPS65086=y > > which ends up with compilation error: > drivers/mfd/tps65086.o: In function `tps65086_probe': > drivers/mfd/tps65086.c:110: undefined reference to > `mfd_add_devices' > drivers/mfd/tps65086.c:110:(.text+0x128): relocation > truncated to fit: R_AARCH64_CALL26 against undefined symbol > `mfd_add_devices' > > Signed-off-by: Michal Simek > --- > > Changes in v2: > - Update commit message based on discussion with Lee Jones > > drivers/mfd/Kconfig | 1 + > 1 file changed, 1 insertion(+) Applied, thanks. > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 94ad2c1c3d90..f98b5a6d4da8 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -1294,6 +1294,7 @@ config TPS6507X > > config MFD_TPS65086 > tristate "TI TPS65086 Power Management Integrated Chips (PMICs)" > + select MFD_CORE > select REGMAP > select REGMAP_IRQ > select REGMAP_I2C -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog