From: Johan Hovold <johan@kernel.org>
To: karthik@techveda.org
Cc: pure.logic@nexus-software.ie, johan@kernel.org, elder@kernel.org,
gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
sunil.m@techveda.org
Subject: Re: [PATCH] staging: greybus: loopback: Enclose multiple macro statements in do-while loop
Date: Tue, 18 Jul 2017 13:04:33 +0200 [thread overview]
Message-ID: <20170718110433.GK29638@localhost> (raw)
In-Reply-To: <1500375400-9617-1-git-send-email-karthik@techveda.org>
On Tue, Jul 18, 2017 at 04:26:40PM +0530, karthik@techveda.org wrote:
> From: Karthik Tummala <karthik@techveda.org>
>
> Enclosed multiple macro statements in a do - while loop as per kernel
> coding standard, pointed by checkpatch.
\
> static DEVICE_ATTR_RO(name##_avg)
>
> -#define gb_loopback_stats_attrs(field) \
> - gb_loopback_ro_stats_attr(field, min, u); \
> - gb_loopback_ro_stats_attr(field, max, u); \
> - gb_loopback_ro_avg_attr(field)
> +#define gb_loopback_stats_attrs(field) \
> +do { \
> + gb_loopback_ro_stats_attr(field, min, u); \
> + gb_loopback_ro_stats_attr(field, max, u); \
> + gb_loopback_ro_avg_attr(field); \
> +} while (0)
You obviously did not even compile-test this before submitting it, which
needless to say, is not ok.
Johan
next prev parent reply other threads:[~2017-07-18 11:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 10:56 karthik
2017-07-18 11:04 ` Johan Hovold [this message]
2017-07-18 11:11 ` Bryan O'Donoghue
2017-07-19 6:40 ` karthik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170718110433.GK29638@localhost \
--to=johan@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=karthik@techveda.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pure.logic@nexus-software.ie \
--cc=sunil.m@techveda.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®