From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751557AbdGRLtk (ORCPT ); Tue, 18 Jul 2017 07:49:40 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:58235 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751535AbdGRLth (ORCPT ); Tue, 18 Jul 2017 07:49:37 -0400 From: Arnd Bergmann To: Jaroslav Kysela , Takashi Iwai Cc: Arnd Bergmann , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/7] ALSA: als100: fix format string overflow warning Date: Tue, 18 Jul 2017 13:48:04 +0200 Message-Id: <20170718114820.3681255-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:MFHEmLSbxWwu0LfD66O2NApKllsMEqDM9v15nYMLWr0laEPxOYq pWco4f3oAugNeMKAJ7ePlHRsqNFdShJWlPm1VLhsLWAISDTeaRI4+fvuHNn8FOFPA9PuPQt mdTTAIcI9cYmsctGHwqoXAQCwdohX0D4U2/3ZJP7B2I7BZiLJnw9bGTyK20LC/26eyOZQeB sFSqKWrnSLXkN+44fxLpg== X-UI-Out-Filterresults: notjunk:1;V01:K0:FU/DEHfgtZs=:N6NtaEuNkg7bb9lB6TtRhA 69qpxl2tZ4/93FXItb7OGNdsttq+rESU8buvc26tvP3tC+bcuYrYUFZKTFJwKOlyPOwfyV0NM HhJee42OFXJctfr5oKel6tWlSBoS94iTNPvcLk4rmUDEJV6rr/y0OHxNil3gmUP+sY4wOMtjw vI1r9d8jEU7BfHMtlUUkVMUTK8WDA+4ytJz765NFVus3GrcqnXJ68dxPGhukiaK5DViIZsS7C sXNWRe1O+xqcT6MFzHdWJ1wY7oGap3Cn+VAt6CvPiIutc7E72LaVSYDY8O/S/qSX6yGPMqkR9 Ai80sL26Ths07pJzRYGxDosAH6/WnQDi2nYB7t3nOJ34FYc4Vo/Glt6Uhldokxl0M974OPil/ ZTLb/vSYk+cUJJ5dy0bfWQ5ScPgpba8l38XpMWJnWYTohhxfe4n7xmwH/Wj1SexFo0CPEiobH Id3sNq2iyzlfwcEjCLZj+2jpYiHjmXqfJJkWoSbjr8KXvzyURMlOUIHL25386p88z8yKA1fQ+ DVCpTEPn2TDBf/i098G4zSgvQoXA0JsJIXMf1kFJ2BmzAsDnfw7YL+utQsrPXotMe66etgQB2 YNNKRILJc+d4IgQjoy45KiI2WKbJh+fR/bWs5sAM664YZZVOFxGZ1+j4nsZCLaLxMqxQozfce igW3zv45zGnHE0hEO2JRfhXPuTMt/nNX9gjZEgiNAbJnct43q4od3rZ4V3Xw4Fypdulpu8MHp 25+a8tc6n7YfrI+Br7HEK3dPvTcnE1st0jhTyQ== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The compiler sees that the format string might overflow for the longname: sound/isa/als100.c: In function 'snd_als100_pnp_detect': sound/isa/als100.c:225:27: error: ', dma ' directive writing 6 bytes into a region of size between 0 and 64 [-Werror=format-overflow=] sprintf(card->longname, "%s, %s at 0x%lx, irq %d, dma %d", ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sound/isa/als100.c:225:3: note: 'sprintf' output between 24 and 113 bytes into a destination of size 80 sprintf(card->longname, "%s, %s at 0x%lx, irq %d, dma %d", Open-coding "shortname" here gets us below the limit, and using snprintf() is a good idea too. Signed-off-by: Arnd Bergmann --- sound/isa/als100.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/sound/isa/als100.c b/sound/isa/als100.c index bc9ea306ee02..6a2c5b48f3ae 100644 --- a/sound/isa/als100.c +++ b/sound/isa/als100.c @@ -222,15 +222,16 @@ static int snd_card_als100_probe(int dev, if (pid->driver_data == SB_HW_DT019X) { strcpy(card->driver, "DT-019X"); strcpy(card->shortname, "Diamond Tech. DT-019X"); - sprintf(card->longname, "%s, %s at 0x%lx, irq %d, dma %d", - card->shortname, chip->name, chip->port, - irq[dev], dma8[dev]); + snprintf(card->longname, sizeof(card->longname), + "Diamond Tech. DT-019X, %s at 0x%lx, irq %d, dma %d", + chip->name, chip->port, irq[dev], dma8[dev]); } else { strcpy(card->driver, "ALS100"); strcpy(card->shortname, "Avance Logic ALS100"); - sprintf(card->longname, "%s, %s at 0x%lx, irq %d, dma %d&%d", - card->shortname, chip->name, chip->port, - irq[dev], dma8[dev], dma16[dev]); + snprintf(card->longname, sizeof(card->longname), + "Avance Logic ALS100, %s at 0x%lx, irq %d, dma %d&%d", + chip->name, chip->port, irq[dev], dma8[dev], + dma16[dev]); } if ((error = snd_sb16dsp_pcm(chip, 0)) < 0) { -- 2.9.0