From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752524AbdGRVGX (ORCPT ); Tue, 18 Jul 2017 17:06:23 -0400 Received: from mail-cys01nam02on0078.outbound.protection.outlook.com ([104.47.37.78]:20710 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752431AbdGRVF5 (ORCPT ); Tue, 18 Jul 2017 17:05:57 -0400 Authentication-Results: embeddedor.com; dkim=none (message not signed) header.d=none;embeddedor.com; dmarc=none action=none header.from=cavium.com; Date: Tue, 18 Jul 2017 14:05:51 -0700 From: Felix Manlunas To: "Gustavo A. R. Silva" Cc: Derek Chickles , Satanand Burla , Felix Manlunas , Raghu Vatsavayi , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] liquidio: lio_main: remove unnecessary static in setup_io_queues() Message-ID: <20170718210551.GB1176@felix-thinkpad.cavium.com> References: <20170718205348.GA25613@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170718205348.GA25613@embeddedgus> User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [50.233.148.156] X-ClientProxiedBy: DM5PR13CA0068.namprd13.prod.outlook.com (10.175.103.158) To DM5PR07MB3179.namprd07.prod.outlook.com (10.172.85.141) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8103fb99-bedb-4dff-e6ec-08d4ce20c814 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(201703131423075)(201703031133081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:DM5PR07MB3179; X-Microsoft-Exchange-Diagnostics: 1;DM5PR07MB3179;3:ldGXZxrxjQEiqV3aK9LvFFpmhxwhdEzbFMPC9vYQVN8FKYqVMnGjL7D/VjSWPkkigN2Y5HsVKylix3gQCNExEYGwnSex4Z8PEPDiADQbOx2rWoAVHGeD1Vrmu9X6nn3ffq/VSGRQnVCdTWw/9FxcSbLhIgnxH40xori8sFO+g+/mSeZ2zRXmQGmMSFjfMfNQIny3conuJNOFkn2/PyPKNQTvN91+e8waU7HrIFJoJdrGFOpnOo6Bhjdrp0W9VBo/0E32T6VWlhMBOKJwvCvTvaG0YaOGCoaITNWbRa/qT7cBwKQJk+A028XsOLXXcYsEGmL1Rqmc+2eR5TI/3hpEdKQbkj1CIKewbS7+HX5W4pBomokOzPX8WRuSKpIPf9mjNnc8hhIcYIHSaQrdV/Eb96mIMBrP7wd+3uc/ivRIf1cLahqnSapYYg4v0tmzqvQ8usMVhw5xM9w9Rlrhq2uKlY7fKqmHsutlok1PJ7wjHE5WFX/UV3fSm8BSDIcuF508YDCOeS5e/hYUEtN65goHeChOVcta4TOXbyM/qj2XuCXNxPHmdyPBGNhP+0NRgRqtKQqGZ0nT0iJcvItC9XQ6Tg48h+AmvGQe99063p3s0NqWBc/Rz/59XJK6VwRDbncLnIz2WP43B5AeYK29JmWHSiAE1rOlzlslwMIIhlBOP/pv/8uRyDKv2NidwruerLjfsuyf+CwVzh6woIaVeX5gDzZcTo3iG7AV2nv2fr5r/jg= X-MS-TrafficTypeDiagnostic: DM5PR07MB3179: X-Microsoft-Exchange-Diagnostics: 1;DM5PR07MB3179;25:sskFn9WLhjJSkNnRFACX3ZttPjy45GWPOb8hnu1mkv+DI3Xv0+WOQ1FmnP1+36v+s4iyeoDmlQWeugEbXpxuWdWZ6t9GIPZQDIUK9NM6I+Rx9bdL9V+KR+aPdFZSS+/f5nb839S+sTX2aVSfJA3jZu4A1NjppQa/ma6sc0MwOEhG9z7DqDdCrvVSICz7X1A2qmAKeUQO7MTNOt5LxfBCkIPWQmkPVaVQxzBiyVaysEpBZQOOENyucZpGFeUE43movyGYo8CuV1RQoxHZwlEPM+hOngKJrVygxQex9ixWTfUsogZfDuLpjzXJMByS2QN2gOLG+qPuekyj5GNWdOqrR1/Ctne/uyLHE1h3c413pshKmlptuEk/HQQY+PVF0c2qfwoXCc89QQSliCTvLfk/su1CtizV7PBHWvZydlq8bA8cIYegv3DzfhlxrbKsfugFJjWnkuqnAx7WDFH7FvUXYFnC2wZe+j3PY64V71d53Q4tppMLpe9F9Wp4e57L4NjAl41+1Q1za85V8UoGy83i49bTZz/uViepGIbTLaYRn5jNWEwH8//yb3ZDdKjfqGA0lCk+VGI4LCZSz73N/IKbwoUm+cGqVwhrojZySJSQee8oa2gLl6E8yK6bPkGC02DWeTtfuCNYTnsLsOqkEkm1mycRztyavuL9lVZq6sSZ9M/UAw9xW4JE1ERLu2MMFYH+zGfkBSo/bQH+Dq+1mxX+Zli03+m2N7Myk1vFNE5ptA5nhBVgwl3Ws+BvBl9/TY3iVfpFKheCICkWjteJ4pncdf0MbF2+DsxUB8tYFRyrzUmeSCFzmxR1mlqKoxPryqz8Yrt6rqNtb4TUO4qDQmwJ9dshuh8/+7zb+aMilFhIeBQlgkQhSEn+iEf3veo8CeQXKAAKUQMLOg+/ic/UXnAkSLb9NAT8YhvIrXfVMcrDRk4= X-Microsoft-Exchange-Diagnostics: 1;DM5PR07MB3179;31:aLpWnGZ+06fu9ylJjiCblA179fPNiPWZcS4H2+hSdw298yY+37RayhsSycMSClPylA4Q4AJXV98UxDIy8UleobRycidI/DItRvaoeUx/st1Tu8XkzNPpvyUBicyln2WHRt3QzAqdzMsN3XlDviid8+iT+7pYnGLjU8a6vwkFatNH299sCWGdChPf478fLaUE1FEnnHJRO6Eyi94crRzi7zUS99snuyZfFzN6TGN5ezKdBf3/E6wtOkAcMSLw9M0Ebadea+tX9/JaMAziIF73dwEdevZe7FJF7W7C3v9WAgLTc7O0cq20Ica3jhA/7MzcRLJAHo3ZwhcvG9BSooFzXq85AhB4OccrcwtXrnjRXWFAdec2kac0GXeDL0S0WdrME7eleNs+MaCeQeyQrCyhcECm6thvMkqU39PpkrPAMQUeZVszq67CqDCDUyPWrzoeH6yUD/5+Jqqy3zg79vOtr9v2nl5Ede6Fs5U2bgIq2c05YfzbHC8jn/n6ITFivx32vaH8f4O3SM/0xqYSS9csRE2ldHtwEm3l7B9fgIrj0OAKN0i89NsbUqA6XGldrS5G25alDkzQtSRYu0SFkFk2d/LoIPz6xbkbzPNz56dbjF85SAw0jIN51B+kJpbyZf+2wc9LdbwDI8Jq/kxlT46HF/RGAVMb3+c8ZnCbXcDozLg= X-Microsoft-Exchange-Diagnostics: 1;DM5PR07MB3179;20:vyZEzNQHGcIms4/Xqc0x32KPL54s6W0IDlHHbbS/DvRRhK7lDvC2mCiPTQJ7ds0Yql+BryQaooLAimJp5UOiljEEHqAEGDg7+465o+vzlSk+SDAh/72A3m/fTF1yt1iKBRwC6dz94rCRbiC3CcZEiuCHvacvAn19P8Cl5av7B12HRSbRnp+p1ofRmb+ge01PoTKmulhSeY2jURlHQwLNRO2bnekrnhSkjAagUg5Idy9etEoHeb0tsS8Yz1oruh1yROx8QsZlh+AIiJhfLihDiy0zGVTVNYRIrFojAjDjrNnllsNSD+sDK3+VKx3nNj3u/6zUsfrB+5Exz0L30BYuZpoN9KPcM3AD5hyV0Z+Bu1yE1phU6F227htJP5FPzwnSbYFNQ05SaSQVgliI3OM9jeDP3W+g3BNCfakm+QXzgVNq6UzYeo8C0jteO4QEEwaRqK1IOTEkKCnh+F9NMMiMcOsP3ti78fiCxrSfOTe422mJgfpCYZVurzZZI0TOUM7O X-Exchange-Antispam-Report-Test: UriScan:(236129657087228); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(2017060910075)(5005006)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(6041248)(20161123560025)(20161123555025)(20161123562025)(20161123564025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DM5PR07MB3179;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DM5PR07MB3179; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM5PR07MB3179;4:GkzKG3IlJ9CypWlgbpPPFrSF/oaZ66pQovfwPMzDcI?= =?us-ascii?Q?nfcKjsMWhf8ad82bD6PlYA8R0feXcnIO1061dLsMAr2qYrMscSfc0yuSjPzW?= =?us-ascii?Q?l+x9Ga0umeo4RxaeLXLn47mBStcoafdFaDxxDy1+ZyJ5QRctDAMVWG1kecFe?= =?us-ascii?Q?fhTgnCGbTx8e1K7kfXw8j/A75hXIaqdA23FSW7RG3A0c5LbFWq0Svxy9qCFr?= =?us-ascii?Q?RPHfkILs/UixWc85kwKrAXmC87EsaMhl5jKA3WOVUY0Ql+OE+t8pjHMbTiPx?= =?us-ascii?Q?de6T7JgnMTRlsuGl2l2ekrK5uxde9XTYE2y1Zkd/PSqkQJR60hxTihxhwKxZ?= =?us-ascii?Q?3HgnWYS2iXvAnzPhWtnvug0nnSicTsng4bqP2Ac/AZn9VqLmvPMn3x2kwnV9?= =?us-ascii?Q?wzLKpS2HbDyS8yvJg7wW9A3QZVQbVXi2/cVUmiso/xqyEgnJlTE3TXIuDttQ?= =?us-ascii?Q?4+jV9C+5K+yBRopXpMZ/uJvvW+tUV2rW8sjIN2Qf9snafDxLxC/IgsFBcvLL?= =?us-ascii?Q?bj61Xu1DjHOq8ZVzlhp1xju/XPp6dvVWphHPyQT7ZtLs4UGpZQXhIglebF/4?= =?us-ascii?Q?xh2qL2clrkC12hV1+Y6zR68vn8IVX76qe5mm2AwzOPFk2KCFh7BRTO3fluFB?= =?us-ascii?Q?Ni5lmO/CHSpMkkVBMWz+E63MdvzPXmeG5Md4NOSzFalrOOeGCx/5fqiWGNaf?= =?us-ascii?Q?WoktNjJbxqKLdB5hmbO/IkiWOWZL9QQwx96K/hstQh875K3OZWS8ACnFL2Q6?= =?us-ascii?Q?nBAUg8amR3GBZgnTDCl9pP4gQMRLg2tkVlO49Izf1UC2XHwD8SKIbWAVryph?= =?us-ascii?Q?KQMuGB2ekpwCiBmIPn+UvINfGVvLyjqeJWDH+kgfBXC+lADph1WK9WP+6vPe?= =?us-ascii?Q?lOmKYwUgazDKP1qHrtocrjcQE3hChxH3rJtN9aTktiDRxfZmIDpWZwH7zLNp?= =?us-ascii?Q?bselAhupfJfHGH9DSIjT+NHuZtdR44wE4mND/ZinjwZ4C/72aRzIo+YhMZVm?= =?us-ascii?Q?ykl9gE4CcUzBC7clw8zS6MwQlrY782IMfwDL90EUcr7tcJgY0DoQUg2XGZ3C?= =?us-ascii?Q?KwjTEm0rJGnmvR1pomT8u8PSccadHyjBE7uKg/CPSOCdLVvepnbP1YP6RmPs?= =?us-ascii?Q?S3T1/rBoO4RJT2nE17QSAD8EJQ09nIQ75f5S3Jdeolh5OCF5myXqTRNqPRDC?= =?us-ascii?Q?a9EHLYdQ9fQjc3AW0iuBMqloLTX2WnmkVuI3W8n7SeXtSmIHO3rr4AxQ=3D?= =?us-ascii?Q?=3D?= X-Forefront-PRVS: 037291602B X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(7370300001)(4630300001)(6009001)(6069001)(39840400002)(39450400003)(39410400002)(39400400002)(24454002)(66066001)(1076002)(6486002)(50466002)(6246003)(229853002)(3846002)(6116002)(8676002)(23726003)(81166006)(110136004)(33656002)(7350300001)(305945005)(7736002)(2950100002)(6916009)(6666003)(54356999)(50986999)(2906002)(478600001)(76176999)(189998001)(86362001)(76506005)(42186005)(25786009)(72206003)(54906002)(47776003)(5660300001)(4001350100001)(4326008)(83506001)(38730400002)(53936002)(6496005)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR07MB3179;H:localhost;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM5PR07MB3179;23:x4gqqQGuDTP/bGw90IPJRpZv76rB5dhlXj6WwtQY/?= =?us-ascii?Q?kIRZPbLPyxPq/ud1q4NlFTxSee5ZQh0eyWQvw/dafI8oRFOwiK72LyX192ah?= =?us-ascii?Q?cVRjayY7204TA3h6LInJaUQUarBJ04RsH1LHeIMIpD+utlfsUWqYCq3qsey4?= =?us-ascii?Q?2F+FVxDvn6au2m2AWv5zAFIv6KSJy+r7+qeHxG0ZNb3nziU92bpgF/bjTLWN?= =?us-ascii?Q?i73CLhPs4mBc1WOySU+NEElg8i6otzueAUs+RwATVAfeXFkVbMm0By63uwQ2?= =?us-ascii?Q?M9QkQayUzVGOcyblCOxw5ens46ATWlAETywPCxfc+B9l3WoCoCyjljI3FBHL?= =?us-ascii?Q?94WqH2Kf85ccfxKNvPSwTppNjTZeTbPe6WkGJrhNGFHDjyDj5YSn42OT08ZW?= =?us-ascii?Q?ZynGDxUvw1cXnnEUWe4TFUIhI0IH6XJrVW7VbXGQSmCydzSSXQBa1b3lcFhe?= =?us-ascii?Q?ds2a9L8NdcOjkTcFuP5kSWTs1dODZ2YX/dgeYjwFs+oIK5n6ixl9AhT3CyKc?= =?us-ascii?Q?1o3Efuw4JqJHPp6ZNJch/e9YV2UstK+n7jDHHU7HgmWkVBqbLAoPHAftNbdR?= =?us-ascii?Q?w8vfcyO0d1V3ppYR1OBl5t+2dy2rnMQ2Wspi9PFCI+rV2b6MQi/kxW3jzoRi?= =?us-ascii?Q?wcVuL1zgp/pnKNnMgAyVEfJ3TGLK7jRVAFfV5hM+euHj27atYAlGX4KhDANb?= =?us-ascii?Q?9DowpJhrs+KAWepq4nLveZKwt+N/XI8NW/07nN2PnADE5yTFgBgRh+bOlROe?= =?us-ascii?Q?tY1QwpbC3XR57xpLhdnR94nsKRp4KjbnWGblAbkBedb1d/DWyeNzb2m9EB0+?= =?us-ascii?Q?m9ApYVNeKubb7PNysPPTPq1mNnlnv2nsQjSZOGKDSDzs1tvNuupYMcKy4+zT?= =?us-ascii?Q?UAUce0R5Qb/cU/sRbaaqHVDlpwWfkWyc4yTuf1vpfpJ1MYO3x0MNmm9ozwQi?= =?us-ascii?Q?D1jxenyYBe+aMMEQXicTd+QPn7gEqtfb6Orj6c4+gg0DbCZqrZFoXkEMofAL?= =?us-ascii?Q?O6IiOJHajChCS+sLPL9l3NShwONbcMjZpGWQH7h8GMeXbWTb9c0L7PA0Wku1?= =?us-ascii?Q?mkxqZ85rYFaNj/5OwkRrZKpuWj52RM0KbHITdy6tsvQGBij9Sk+jV0OksIgF?= =?us-ascii?Q?CyNrG6KmvgUsY9Rg+6TLE773X0IX0pBMD7WPvHKgXI6YkcHVx0VjhydV7XhW?= =?us-ascii?Q?gD2f/hTVQYvfzf1FLrkLQRThAKU3hpeI0JJYdBaInE+bk4NqVHFXil5pA=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM5PR07MB3179;6:fHDK5VDxWHVaD0QmVwgs42FSFPDt9fFbG1ggPcTs1L?= =?us-ascii?Q?oXON+tHlcp3xpvCCowV6d5yorGDFk9hxF6SfFqxa6mvplkt97H0KfYcvx+GD?= =?us-ascii?Q?eWj84rIaNj3Pa0/zhSOpuG9kml8wwIQj4rCm2zrPM/N5mWOvlSosS6fA+e2/?= =?us-ascii?Q?OqoDod1LK5u/SyKJmWlD3ARju7mUkb5w9jJZVYAUyuAC0XNPwIPvDqz2npqy?= =?us-ascii?Q?GFCfaHk5qg3Ifbh7T7tDEkAYCmUrjQG0dbfXb2Fvaln4Oxcin2Q+sqJlL1bH?= =?us-ascii?Q?jWk/s3BeJ6M3WLi2veUhC4FKKGHM0yf9oMWnIt5h6l+HaXFcouT9KeBkUd+r?= =?us-ascii?Q?fXw+DLhyqW3jrm6GM0lyIIECNoFjwlNTQBItY9J0mnq1aTUUXk3fMYvWNWvt?= =?us-ascii?Q?UO9gyJcKP/M3/bvZ43g7mCdr1BG17M9uvYwUoURt5/AkZlqa3sS04M7Vg92G?= =?us-ascii?Q?djtrvWpQgBpg0CWXKGPXPAnyx8OkuBjXyCvFRJWCp74gCbdg1+iPi6B5zKag?= =?us-ascii?Q?1rwP7NmQsPCoWczfgYuMD/Rl85Iz/zUwyUO3EmhIQCTyMRSe9hmixuk2kdW5?= =?us-ascii?Q?FvjUGfYPvpxp8u6IvBR9Dd8Vm8oJcbuFttcILD/4VD6r7cvPNj/NK6f0j4su?= =?us-ascii?Q?QGMrG1OJh1oeGq4U32YRjCXpXIY+m/C/E9D0MJSJmITx0gJNcfFUjFVjnByL?= =?us-ascii?Q?Sm1k0uup3fW7FZysd7IShnVeM3/Q9w+ktLKz66A70uDUuTCuyFFeCTCh0PYv?= =?us-ascii?Q?Gl+pwszXE8C8jhrkX6760egu2dCoQS36QRsmX37RdvGtJmemWS71jC35yMLt?= =?us-ascii?Q?sc1YcRetS9Vqtrc3YNMGx24t6/zeLgGKwjv2QIi32iKRPPX6GZtT7ahPXJuZ?= =?us-ascii?Q?Y3KK0SEgDyw/8L/B+rAssK6c0V/g+ok3IWrqkpUrNEg9r6joXb5rVv75jXAL?= =?us-ascii?Q?ro6t3d3zkg0HCj2OlphdPgooD5b+F/egi3VgvqrXeJJ7e429ZScB0tDpwy/l?= =?us-ascii?Q?w=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR07MB3179;5:s26JOnavfj6vxoidmF2gMCas4Q5xXjCRujj1BSm+E8eA5BFsr7b1ywZEj0Db/S6POynI3uFHrGvX7Vz1qLwp0Q+nvaBOIbjZhDq/fmrb9T48u3M8zzu6JPieMzl9wX0lB9xzun7Y9jdIU6VdNjYTc9isxwZTA79wn7nyvQFG29pA/oifDzDlWR7+Lf8RXIxhe77CNgdxg/sDMI+Xb4DYtsmjUOYCiohGnysu7olOdNpXWY/xHWKSHlHeRbmYaesEa9WKpVB0OCV9hktOMAe5dAYQJF3FYQWIwcf08IvDV39oiwp3KWH5ap9HJktC4ps2fyJuu9KCdyPSIam/tHSAuOmBOzXcKBcC6FKXEa0dOQ9EMwIHZOehNMS0JEBAFKVwU5OPs1oLVs/O7R4osQjxf2NT8BSWA9N3qgOnQsqTbNgM5F7lr5UvfxjrTSrWir03PYhLzFJyWdegJTsLFR0YnfwMAV7RwO09FwznzLz5muu89RZHwwFBpw7trd+dHjl7;24:x/76G4PqrA7/xlC1lEvNu3N+AZV6mc158vTnXb/e6PUKbIWPyKlB+tIDIDRI3s0GYdbR319WpLbILqbphqeoE12zwRHzapzOytNX9hBIDYI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR07MB3179;7:VEgszhjIAtSqvf0XFdLpuR+cUJw7Gwtz2KPrNN3XJrB4BEQmmJQ+MoQdTdRSBMg3AXjZRaNkImZxVkvpGfhvKvehVYfIuHs+ecGog86u6LceJ9Yd2LPhaoK7BMs8T9KtGskkvUAryQOJ1GYo1J8HrypsLYxrV5B0fTrN+6WfwYT8EE4nnfoD5kSK5utxZigeXK+ni8+SvEwMuwW29utifTBv8Kgf2zTItkAJVbJtR58EwtgfgZyQE+FMcMJROG6vbX48b6gJD1/Bmn6aN1PTgAZWVMPDpLcX557Un/0WseC/1v4d+rMshDRqDmI4QGGC9tVdqz+q6uaiYNcCeARhhlcFcoULPVIkc9QbZbK61zqqJdpRt2CWJClPWf6IwNY1ENhFhhuMvD+4c1g/ELhsL6xpWkjImmGukxYLgO/b2rtTx35aqSSZplEH01a5aTzePkY/fjLYNzazirZJ+TAwfZd0+9pTPIpwn75FycdhlqFALP9w7A1aTg+VzEn1gW9KJZR229GxIPBJD0Pwyl3h0azVKTt07kr5ozDOToYh+rw530dVBtQRpNzMNQraMIuxZC3QNkz4Refk3cQB3KV9zuRngR1nGtL//qo+izlKeDo9Cx2soxVBIggrhMBr+fMh6c7tsZIXvFDaDhV4XGwhUpelWrQDtAj7c2cxJmrlMUygG9X832dMNsRE85LkHSDFWn4VUkiEUFXexLBKwSYk+W1xWADG6fUnnVAphd8MApPXgt9/bdiQYB6guGwdc935Oyr7POaeknbL/E6Zx/jrhEQRwA2GSlD3ONocsWEUwM8= X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2017 21:05:55.5608 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3179 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 18, 2017 at 03:53:48PM -0500, Gustavo A. R. Silva wrote: > Remove unnecessary static on local variables cpu_id_modulus and cpu_id. > Such variables are initialized before being used, on every execution > path throughout the function. The static has no benefit and, removing > it reduces the object file size. > > This issue was detected using Coccinelle and the following semantic patch: > > @bad exists@ > position p; > identifier x; > type T; > @@ > > static T x@p; > ... > x = <+...x...+> > > @@ > identifier x; > expression e; > type T; > position p != bad.p; > @@ > > -static > T x@p; > ... when != x > when strict > ?x = e; > > In the following log you can see a significant difference in the object > file size. Also, there is a significant difference in the bss segment. > This log is the output of the size command, before and after the code > change: > > before: > text data bss dec hex filename > 78689 15272 27808 121769 1dba9 drivers/net/ethernet/cavium/liquidio/lio_main.o > > after: > text data bss dec hex filename > 78667 15128 27680 121475 1da83 drivers/net/ethernet/cavium/liquidio/lio_main.o > > Signed-off-by: Gustavo A. R. Silva > --- > drivers/net/ethernet/cavium/liquidio/lio_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c b/drivers/net/ethernet/cavium/liquidio/lio_main.c > index 51583ae..1d8fefa 100644 > --- a/drivers/net/ethernet/cavium/liquidio/lio_main.c > +++ b/drivers/net/ethernet/cavium/liquidio/lio_main.c > @@ -2544,8 +2544,8 @@ static inline int setup_io_queues(struct octeon_device *octeon_dev, > { > struct octeon_droq_ops droq_ops; > struct net_device *netdev; > - static int cpu_id; > - static int cpu_id_modulus; > + int cpu_id; > + int cpu_id_modulus; > struct octeon_droq *droq; > struct napi_struct *napi; > int q, q_no, retval = 0; > -- > 2.5.0 > Thanks. Acked-by: Felix Manlunas