From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754960AbdGSXfI (ORCPT ); Wed, 19 Jul 2017 19:35:08 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:49064 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754982AbdGSXfE (ORCPT ); Wed, 19 Jul 2017 19:35:04 -0400 Date: Wed, 19 Jul 2017 16:35:04 -0700 (PDT) Message-Id: <20170719.163504.1972586469015417785.davem@davemloft.net> To: gustavo@embeddedor.com Cc: harish.patil@cavium.com, manish.chopra@cavium.com, Dept-GELinuxNICDev@cavium.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] qlcnic: remove unnecessary static in qlcnic_dump_fw() From: David Miller In-Reply-To: <20170718204529.GA11448@embeddedgus> References: <20170718204529.GA11448@embeddedgus> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 19 Jul 2017 16:35:04 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Gustavo A. R. Silva" Date: Tue, 18 Jul 2017 15:45:29 -0500 > Remove unnecessary static on local variable fw_dump_ops. > Such variable is initialized before being used, on every > execution path throughout the function. The static has no > benefit and, removing it reduces the object file size. > > This issue was detected using Coccinelle and the following semantic patch: ... > Signed-off-by: Gustavo A. R. Silva Applied.