From: Greg KH <gregkh@linuxfoundation.org>
To: Joe Perches <joe@perches.com>
Cc: Jaya Durga <rjdurga@gmail.com>,
lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org,
knaack.h@gmx.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] Staging: speakup: speakup_keypc.c: usleep_range is preferred over udelay
Date: Wed, 19 Jul 2017 14:45:54 +0200 [thread overview]
Message-ID: <20170719124554.GA17490@kroah.com> (raw)
In-Reply-To: <1500467788.25934.37.camel@perches.com>
On Wed, Jul 19, 2017 at 05:36:28AM -0700, Joe Perches wrote:
> On Wed, 2017-07-19 at 17:55 +0530, Jaya Durga wrote:
> > Fix checkpatch issue: CHECK: usleep_range is preferred over udelay;
> []
> > diff --git a/drivers/staging/speakup/speakup_keypc.c b/drivers/staging/speakup/speakup_keypc.c
> []
> > @@ -28,7 +28,7 @@
> >
> > #define DRV_VERSION "2.10"
> > #define SYNTH_IO_EXTENT 0x04
> > -#define SWAIT udelay(70)
> > +#define SWAIT usleep_range(70, 150)
>
> It'd probably be more sensible to remove this define as
> SWAIT is used just once and use usleep_range directly.
>
I asked for that last time :(
I guess I'll just reject this again...
prev parent reply other threads:[~2017-07-19 12:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 12:25 Jaya Durga
2017-07-19 12:25 ` [PATCH v3 2/3] Staging: iio: light: tsl2x7x_core.c: Replace symbolic permission with octal permission Jaya Durga
2017-07-22 20:34 ` Jonathan Cameron
2017-07-19 12:25 ` [PATCH v3 3/3] Staging: iio: adc: ad7280a.c: Fixed Macro argument reuse Jaya Durga
2017-07-22 20:37 ` Jonathan Cameron
2017-07-19 12:36 ` [PATCH v3 1/3] Staging: speakup: speakup_keypc.c: usleep_range is preferred over udelay Joe Perches
2017-07-19 12:45 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170719124554.GA17490@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Michael.Hennerich@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=jic23@kernel.org \
--cc=joe@perches.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=rjdurga@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome