From: Dave Jones <davej@codemonkey.org.uk>
To: Chris Metcalf <cmetcalf@mellanox.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
kasan-dev@googlegroups.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Chris Metcalf <cmetcalf@ezchip.com>
Subject: Re: [PATCH] lib/strscpy: avoid KASAN false positive
Date: Wed, 19 Jul 2017 12:05:32 -0400 [thread overview]
Message-ID: <20170719160532.st4tr3jxeerwmq4h@codemonkey.org.uk> (raw)
In-Reply-To: <8cf46473-062e-1b7c-1756-aea57daa8e65@mellanox.com>
On Wed, Jul 19, 2017 at 11:39:32AM -0400, Chris Metcalf wrote:
> > We could just remove all that word-at-a-time logic. Do we have any
> > evidence that this would harm anything?
>
> The word-at-a-time logic was part of the initial commit since I wanted
> to ensure that strscpy could be used to replace strlcpy or strncpy without
> serious concerns about performance.
I'm curious what the typical length of the strings we're concerned about
in this case are if this makes a difference.
Dave
next prev parent reply other threads:[~2017-07-19 16:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 17:15 Andrey Ryabinin
2017-07-18 17:14 ` Dmitry Vyukov
2017-07-18 17:22 ` Linus Torvalds
2017-07-18 20:15 ` Andrey Ryabinin
2017-07-18 20:26 ` Linus Torvalds
2017-07-18 21:31 ` Andrey Ryabinin
2017-07-18 21:32 ` Andrey Ryabinin
2017-07-18 22:04 ` Andrew Morton
2017-07-18 22:35 ` Linus Torvalds
2017-07-19 7:46 ` Dmitry Vyukov
2017-07-19 15:39 ` Chris Metcalf
2017-07-19 16:05 ` Dave Jones [this message]
2017-07-26 12:05 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170719160532.st4tr3jxeerwmq4h@codemonkey.org.uk \
--to=davej@codemonkey.org.uk \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=cmetcalf@ezchip.com \
--cc=cmetcalf@mellanox.com \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®