From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936265AbdGTTiH (ORCPT ); Thu, 20 Jul 2017 15:38:07 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:34890 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934079AbdGTTiF (ORCPT ); Thu, 20 Jul 2017 15:38:05 -0400 Date: Thu, 20 Jul 2017 12:38:04 -0700 (PDT) Message-Id: <20170720.123804.318219961537845081.davem@davemloft.net> To: krzk@kernel.org Cc: sam@ravnborg.org, linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org Subject: Re: [RESEND PATCH] sparc: defconfig: Cleanup from old Kconfig options From: David Miller In-Reply-To: <20170720181124.GA2874@kozik-book> References: <1500526855-4132-1-git-send-email-krzk@kernel.org> <20170720123633.GA7465@ravnborg.org> <20170720181124.GA2874@kozik-book> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 20 Jul 2017 12:38:05 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Krzysztof Kozlowski Date: Thu, 20 Jul 2017 20:11:24 +0200 > On Thu, Jul 20, 2017 at 02:36:33PM +0200, Sam Ravnborg wrote: >> On Thu, Jul 20, 2017 at 07:00:55AM +0200, Krzysztof Kozlowski wrote: >> > Remove old, dead Kconfig options (in order appearing in this commit): >> > - EXPERIMENTAL is gone since v3.9; >> > - INET_LRO: commit 7bbf3cae65b6 ("ipv4: Remove inet_lro library"); >> > - AUTOFS_FS: commit 561c5cf9236a ("staging: Remove autofs3"); >> > - RCU_CPU_STALL_DETECTOR: commit a00e0d714fbd ("rcu: Remove conditional >> > compilation for RCU CPU stall warnings"); >> > - USB_DEVICE_CLASS: commit 007bab91324e ("USB: remove >> > CONFIG_USB_DEVICE_CLASS"); >> > - SYSCTL_SYSCALL_CHECK: commit 7c60c48f58a7 ("sysctl: Improve the >> > sysctl sanity checks"); >> > >> > Signed-off-by: Krzysztof Kozlowski >> > Acked-by: David S. Miller >> >> Hi Krzysztof. >> >> This looks like a manually edited defconfig. >> A better approch would be to do: >> $ make ARCH=sparc64 sparc64_defconfig >> $ make ARCH=sparc64 savedefconfig >> >> And then to check the generated defconfig. >> Same for sparc32. > > Actually this was generated with sed instead of defconfig on purpose - > as part of my bigger cleanup starting from ARM [1]. In case of > defconfigs for my platform we wanted to preserve the explanation why > things are disappearing, not only to savedefconfig. Indeed this brought > up that few items from savedefconfig would be gone but should be > replaced with different (new) items. > > Anyway this way you have a full control and explanation why things are > being changed. After this you can always run defconfig to reorganize and > clean up. > > [1] https://www.linux-mips.org/archives/linux-mips/2017-06/msg00255.html Yeah I guess this is OK for now. But we should do a tool based regen at some point soon. Applied, thanks.