From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936620AbdGTT6w (ORCPT ); Thu, 20 Jul 2017 15:58:52 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:35210 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934707AbdGTT6v (ORCPT ); Thu, 20 Jul 2017 15:58:51 -0400 Date: Thu, 20 Jul 2017 12:58:50 -0700 (PDT) Message-Id: <20170720.125850.1894569815191415786.davem@davemloft.net> To: vijay.ac.kumar@oracle.com Cc: sparclinux@vger.kernel.org, rob.gardner@oracle.com, anthony.yznaga@oracle.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] sparc64: Use cpu_poke to resume idle cpu From: David Miller In-Reply-To: <1499545424-415240-3-git-send-email-vijay.ac.kumar@oracle.com> References: <1499545424-415240-1-git-send-email-vijay.ac.kumar@oracle.com> <1499545424-415240-3-git-send-email-vijay.ac.kumar@oracle.com> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 20 Jul 2017 12:58:50 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vijay Kumar Date: Sat, 8 Jul 2017 14:23:44 -0600 > diff --git a/arch/sparc/kernel/hvapi.c b/arch/sparc/kernel/hvapi.c > index 2677312..0b070d5 100644 > --- a/arch/sparc/kernel/hvapi.c > +++ b/arch/sparc/kernel/hvapi.c > @@ -189,7 +189,7 @@ void __init sun4v_hvapi_init(void) > > group = HV_GRP_CORE; > major = 1; > - minor = 1; > + minor = 6; /* CPU POKE */ > if (sun4v_hvapi_register(group, major, &minor)) > goto bad; That CPU POKE comment will not stand the test of time, please remove it. > + /* Use cpu poke to resume idle cpu if supported*/ Please put a space at the end of the comment and before the "*/" > + /*cpu poke is registered. */ Please put a space at the beginning of the comment. And you should decide which way you want to consistently write. Either capitalize the first word and finish the sentence with a '.', or don't. Do it the same way each time. Thanks.