From: Christoph Hellwig <hch@lst.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Amir Goldstein <amir73il@gmail.com>,
Andreas Noever <andreas.noever@gmail.com>,
Michael Jamet <michael.jamet@intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Yehezkel Bernat <yehezkel.bernat@intel.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 1/3] uuid: fix incorrect uuid_equal conversion in test_uuid_test
Date: Thu, 20 Jul 2017 09:56:22 +0200 [thread overview]
Message-ID: <20170720075624.25619-2-hch@lst.de> (raw)
In-Reply-To: <20170720075624.25619-1-hch@lst.de>
Fixes: df33767d ("uuid: hoist helpers uuid_equal() and uuid_copy() from xfs")
Reported-by: kernel test robot <xiaolong.ye@intel.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
lib/test_uuid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/test_uuid.c b/lib/test_uuid.c
index 478c049630b5..cd819c397dc7 100644
--- a/lib/test_uuid.c
+++ b/lib/test_uuid.c
@@ -82,7 +82,7 @@ static void __init test_uuid_test(const struct test_uuid_data *data)
test_uuid_failed("conversion", false, true, data->uuid, NULL);
total_tests++;
- if (uuid_equal(&data->be, &be)) {
+ if (!uuid_equal(&data->be, &be)) {
sprintf(buf, "%pUb", &be);
test_uuid_failed("cmp", false, true, data->uuid, buf);
}
--
2.11.0
next prev parent reply other threads:[~2017-07-20 7:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 7:56 uuid updates for 4.13-rc Christoph Hellwig
2017-07-20 7:56 ` Christoph Hellwig [this message]
2017-07-20 8:59 ` [PATCH 1/3] uuid: fix incorrect uuid_equal conversion in test_uuid_test Amir Goldstein
2017-07-20 7:56 ` [PATCH 2/3] thunderbold: use uuid_t instead of uuid_be Christoph Hellwig
2017-07-20 9:01 ` Amir Goldstein
2017-07-24 9:28 ` Mika Westerberg
2017-07-24 15:50 ` Christoph Hellwig
2017-07-20 7:56 ` [PATCH 3/3] uuid: remove uuid_be Christoph Hellwig
2017-07-20 9:09 ` uuid updates for 4.13-rc Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170720075624.25619-2-hch@lst.de \
--to=hch@lst.de \
--cc=amir73il@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.jamet@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=yehezkel.bernat@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®