From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935761AbdGTJPs (ORCPT ); Thu, 20 Jul 2017 05:15:48 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:48944 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935196AbdGTJPq (ORCPT ); Thu, 20 Jul 2017 05:15:46 -0400 Date: Thu, 20 Jul 2017 11:15:38 +0200 From: Greg Kroah-Hartman To: Ingo Molnar Cc: Colin King , Vitaly Kuznetsov , "K . Y . Srinivasan" , Haiyang Zhang , Stephen Hemminger , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , x86@kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] x86/hyper-v: add missing void return type to hyperv_cleanup declaration Message-ID: <20170720091538.GB27647@kroah.com> References: <20170719090859.9248-1-colin.king@canonical.com> <20170720085236.xwer2iatjl5vjta6@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170720085236.xwer2iatjl5vjta6@gmail.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 20, 2017 at 10:52:36AM +0200, Ingo Molnar wrote: > > * Colin King wrote: > > > From: Colin Ian King > > > > Add in missing void return type, fixes sparse warning: > > "warning: 'hyperv_cleanup()' has implicit return type" > > > > Fixes: 2e252fbf777d ("x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set") > > Signed-off-by: Colin Ian King > > --- > > arch/x86/include/asm/mshyperv.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h > > index 01b9c0fb3aab..41fae263f8fa 100644 > > --- a/arch/x86/include/asm/mshyperv.h > > +++ b/arch/x86/include/asm/mshyperv.h > > @@ -178,7 +178,7 @@ void hyperv_cleanup(void); > > #else /* CONFIG_HYPERV */ > > static inline void hyperv_init(void) {} > > static inline bool hv_is_hypercall_page_setup(void) { return false; } > > -static inline hyperv_cleanup(void) {} > > +static inline void hyperv_cleanup(void) {} > > #endif /* CONFIG_HYPERV */ > > Guys, Greg, could we please move this commit from the drivers tree: > > 2e252fbf777d: x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set > > arch/x86/Kbuild | 2 +- > arch/x86/include/asm/mshyperv.h | 7 ++++++- > > ... to the x86 tree where it belongs? I've now reverted it from my tree entirely, sorry about that. greg k-h