From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754788AbdGUUSu (ORCPT ); Fri, 21 Jul 2017 16:18:50 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:54540 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753602AbdGUUSs (ORCPT ); Fri, 21 Jul 2017 16:18:48 -0400 From: Arnd Bergmann To: linux-pcmcia@lists.infradead.org, Russell King Cc: Andrew Morton , Arnd Bergmann , linux-kernel@vger.kernel.org Subject: [PATCH] [RESEND] pcmcia: badge4: avoid unused function warning Date: Fri, 21 Jul 2017 22:18:06 +0200 Message-Id: <20170721201817.3359242-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:MAO06nTGCHkM6XQbtY/1pssdv4a/OcryuI1hhh1Ww79cnToHvzv vf37kPNGf8hE43RFDz1z8JlANoLQd3xLsJdCyP0sw6/wo5BQA87Sa1M9M+V17jsWN+321g9 FpkqywDQNQpDnc74CGg0Href5RnZ+1coCcRSTW9EUwnBNedz9ib0QZWvhx6mbRYei8b9O5F 1HKjbzcZhjw2LoPMX3YkQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:Wx4c5M0jn2w=:GbPHyV0Ag8CR+/GW0kAAVl EYlZUhP8BPoq8h1BoBw5QbGS42kHygn/ybyrnltJj2VCGjvxt0UCbDbEbtleSMmvOGl6y6k23 fbtyHjbjNIX4YBQQnZzFiC7ND2kIJC6dRlTb50kuPjiiLjV85LXTMp3Kt2VHKLcDvEqB4QqdW q90irwgwDOnqvohAAni6TKs2k+ZykB8N/IlGbTWV8cNs5PBT084yjrvoXUipvdRzoSqJEv2HT KyInyQOI1R23dZNDBKiLQPV6rG8GSXIblPe3Y9w36SzLxuSyHKrw7gAcIY61LgrKTLKGuAp30 yko1BvBurjxtzc0jIqjJLbJCJCA2pnJv6IkWPuxzDM81eHc9D+80QcOzBnDc6ZgQM9+Ki/xq+ B008t2oekvMSQZ4t8unlUmKw6xdmfs55KchoJ66+Hq0gx68mOq8WVsVpOI9oDl7+0R1UMmwz0 QHX1Lda6GBZ1zJUKEtCCFkHEd+p4qaTZGt1/7zp6nMDnA+KwYWfBd74qdDkFv6QIgprQm62A8 e+JO/soD3/c0EC8567oodtbp/86eyJHLcGkndqXHNbld5NU3GMU2eg9y4Kuk81zrwrQrPBK/g X7w2nPAui64C/raH5eBm5FLM7e3hSqfsAJeGglkQGGYKJZ+7qOvTQzh8dTCWpA6oLmDXshHlP RU/jI/nCWL8jGQE7trlpNmQn25yf+PlvZqY7iqp1TswyIAQqsrDzOPInk/XfsV8u8IszGO065 HdMrM29YjXemlJN5cf20GkoAYa2shZBuYuNdWA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The pcmv_setup is only used when the badge4 driver is built-in, but not when it is a loadable module: drivers/pcmcia/sa1111_badge4.c:153:122: error: 'pcmv_setup' defined but not used [-Werror=unused-function] This adds an #ifdef to avoid the definition of the unused function in the modular case. Signed-off-by: Arnd Bergmann --- Patch was sent on Jan 25 2016, no reply, resending --- drivers/pcmcia/sa1111_badge4.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pcmcia/sa1111_badge4.c b/drivers/pcmcia/sa1111_badge4.c index 2f490930430d..93a5c7423d80 100644 --- a/drivers/pcmcia/sa1111_badge4.c +++ b/drivers/pcmcia/sa1111_badge4.c @@ -144,6 +144,7 @@ int pcmcia_badge4_init(struct sa1111_dev *dev) sa11xx_drv_pcmcia_add_one); } +#ifndef MODULE static int __init pcmv_setup(char *s) { int v[4]; @@ -158,3 +159,4 @@ static int __init pcmv_setup(char *s) } __setup("pcmv=", pcmv_setup); +#endif -- 2.9.0