From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751954AbdGVGAK (ORCPT ); Sat, 22 Jul 2017 02:00:10 -0400 Received: from mx2.suse.de ([195.135.220.15]:43053 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750798AbdGVGAI (ORCPT ); Sat, 22 Jul 2017 02:00:08 -0400 Date: Sat, 22 Jul 2017 07:59:54 +0200 From: Borislav Petkov To: Loc Ho Cc: msalter@redhat.com, rafael@kernel.org, tbaicar@codeaurora.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, patches@apm.com Subject: Re: [PATCH v6 1/1] acpi: apei: Enable APEI multiple GHES source to share a single external IRQ Message-ID: <20170722055954.GA2082@nazgul.tnic> References: <1500661477-6536-1-git-send-email-lho@apm.com> <1500661477-6536-2-git-send-email-lho@apm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1500661477-6536-2-git-send-email-lho@apm.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 21, 2017 at 11:24:37AM -0700, Loc Ho wrote: > X-Gene platforms describe multiple GHES error sources with the same hardware > error notification type (external interrupt) and interrupt number. > Change the GHES interrupt request to support sharing the same IRQ. > > Co-authored-by: Tuan Phan > Signed-off-by: Loc Ho > --- > drivers/acpi/apei/ghes.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c > index d661d45..eed09fc 100644 > --- a/drivers/acpi/apei/ghes.c > +++ b/drivers/acpi/apei/ghes.c > @@ -1157,7 +1157,8 @@ static int ghes_probe(struct platform_device *ghes_dev) > generic->header.source_id); > goto err_edac_unreg; > } > - rc = request_irq(ghes->irq, ghes_irq_func, 0, "GHES IRQ", ghes); > + rc = request_irq(ghes->irq, ghes_irq_func, IRQF_SHARED, > + "GHES IRQ", ghes); > if (rc) { > pr_err(GHES_PFX "Failed to register IRQ for generic hardware error source: %d\n", > generic->header.source_id); > -- Acked-by: Borislav Petkov -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --