From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753904AbdGVOxW (ORCPT ); Sat, 22 Jul 2017 10:53:22 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:49895 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751328AbdGVOxU (ORCPT ); Sat, 22 Jul 2017 10:53:20 -0400 Date: Sat, 22 Jul 2017 07:53:17 -0700 From: Guenter Roeck To: Sebastian Reichel Cc: Sebastian Reichel , Support Opensource , Lee Jones , Rob Herring , Mark Rutland , Jean Delvare , devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv6,3/4] hwmon: da9052: replace S_IRUGO with 0444 Message-ID: <20170722145317.GA12511@roeck-us.net> References: <20170718092024.22552-4-sebastian.reichel@collabora.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170718092024.22552-4-sebastian.reichel@collabora.co.uk> User-Agent: Mutt/1.5.24 (2015-08-30) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sebastian, On Tue, Jul 18, 2017 at 11:20:23AM +0200, Sebastian Reichel wrote: > Fix checkpatch warnings about S_IRUGO being less readable than > providing the permissions octal as '0444'. > > Signed-off-by: Sebastian Reichel Again: Acked-by: Guenter Roeck If you don't make changes, please don't drop already provided Reviewed-by: or Acked-by: tags. You are making it unnecessarily hard on us, forcing us to re-review your patches. Sure, it only takes a few minutes to track down the previous version of your patches, compare it to this version, and send another Ack. But it is a few minutes of _my_ time. Thanks, Guenter > --- > drivers/hwmon/da9052-hwmon.c | 36 ++++++++++++++++++------------------ > 1 file changed, 18 insertions(+), 18 deletions(-) > > diff --git a/drivers/hwmon/da9052-hwmon.c b/drivers/hwmon/da9052-hwmon.c > index c9832bfacfe5..708c91ac601f 100644 > --- a/drivers/hwmon/da9052-hwmon.c > +++ b/drivers/hwmon/da9052-hwmon.c > @@ -196,43 +196,43 @@ static ssize_t show_label(struct device *dev, > input_names[to_sensor_dev_attr(devattr)->index]); > } > > -static SENSOR_DEVICE_ATTR(in0_input, S_IRUGO, da9052_read_vddout, NULL, > +static SENSOR_DEVICE_ATTR(in0_input, 0444, da9052_read_vddout, NULL, > DA9052_ADC_VDDOUT); > -static SENSOR_DEVICE_ATTR(in0_label, S_IRUGO, show_label, NULL, > +static SENSOR_DEVICE_ATTR(in0_label, 0444, show_label, NULL, > DA9052_ADC_VDDOUT); > -static SENSOR_DEVICE_ATTR(in3_input, S_IRUGO, da9052_read_vbat, NULL, > +static SENSOR_DEVICE_ATTR(in3_input, 0444, da9052_read_vbat, NULL, > DA9052_ADC_VBAT); > -static SENSOR_DEVICE_ATTR(in3_label, S_IRUGO, show_label, NULL, > +static SENSOR_DEVICE_ATTR(in3_label, 0444, show_label, NULL, > DA9052_ADC_VBAT); > -static SENSOR_DEVICE_ATTR(in4_input, S_IRUGO, da9052_read_misc_channel, NULL, > +static SENSOR_DEVICE_ATTR(in4_input, 0444, da9052_read_misc_channel, NULL, > DA9052_ADC_IN4); > -static SENSOR_DEVICE_ATTR(in4_label, S_IRUGO, show_label, NULL, > +static SENSOR_DEVICE_ATTR(in4_label, 0444, show_label, NULL, > DA9052_ADC_IN4); > -static SENSOR_DEVICE_ATTR(in5_input, S_IRUGO, da9052_read_misc_channel, NULL, > +static SENSOR_DEVICE_ATTR(in5_input, 0444, da9052_read_misc_channel, NULL, > DA9052_ADC_IN5); > -static SENSOR_DEVICE_ATTR(in5_label, S_IRUGO, show_label, NULL, > +static SENSOR_DEVICE_ATTR(in5_label, 0444, show_label, NULL, > DA9052_ADC_IN5); > -static SENSOR_DEVICE_ATTR(in6_input, S_IRUGO, da9052_read_misc_channel, NULL, > +static SENSOR_DEVICE_ATTR(in6_input, 0444, da9052_read_misc_channel, NULL, > DA9052_ADC_IN6); > -static SENSOR_DEVICE_ATTR(in6_label, S_IRUGO, show_label, NULL, > +static SENSOR_DEVICE_ATTR(in6_label, 0444, show_label, NULL, > DA9052_ADC_IN6); > -static SENSOR_DEVICE_ATTR(in9_input, S_IRUGO, da9052_read_vbbat, NULL, > +static SENSOR_DEVICE_ATTR(in9_input, 0444, da9052_read_vbbat, NULL, > DA9052_ADC_VBBAT); > -static SENSOR_DEVICE_ATTR(in9_label, S_IRUGO, show_label, NULL, > +static SENSOR_DEVICE_ATTR(in9_label, 0444, show_label, NULL, > DA9052_ADC_VBBAT); > > -static SENSOR_DEVICE_ATTR(curr1_input, S_IRUGO, da9052_read_ich, NULL, > +static SENSOR_DEVICE_ATTR(curr1_input, 0444, da9052_read_ich, NULL, > DA9052_ADC_ICH); > -static SENSOR_DEVICE_ATTR(curr1_label, S_IRUGO, show_label, NULL, > +static SENSOR_DEVICE_ATTR(curr1_label, 0444, show_label, NULL, > DA9052_ADC_ICH); > > -static SENSOR_DEVICE_ATTR(temp2_input, S_IRUGO, da9052_read_tbat, NULL, > +static SENSOR_DEVICE_ATTR(temp2_input, 0444, da9052_read_tbat, NULL, > DA9052_ADC_TBAT); > -static SENSOR_DEVICE_ATTR(temp2_label, S_IRUGO, show_label, NULL, > +static SENSOR_DEVICE_ATTR(temp2_label, 0444, show_label, NULL, > DA9052_ADC_TBAT); > -static SENSOR_DEVICE_ATTR(temp8_input, S_IRUGO, da9052_read_tjunc, NULL, > +static SENSOR_DEVICE_ATTR(temp8_input, 0444, da9052_read_tjunc, NULL, > DA9052_ADC_TJUNC); > -static SENSOR_DEVICE_ATTR(temp8_label, S_IRUGO, show_label, NULL, > +static SENSOR_DEVICE_ATTR(temp8_label, 0444, show_label, NULL, > DA9052_ADC_TJUNC); > > static struct attribute *da9052_attrs[] = {