From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755326AbdGWMPy (ORCPT ); Sun, 23 Jul 2017 08:15:54 -0400 Received: from mail-qk0-f181.google.com ([209.85.220.181]:33984 "EHLO mail-qk0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751649AbdGWMPw (ORCPT ); Sun, 23 Jul 2017 08:15:52 -0400 Date: Sun, 23 Jul 2017 08:15:48 -0400 From: Tejun Heo To: Li Zefan , Johannes Weiner Cc: cgroups@vger.kernel.org, kernel-team@fb.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH cgroup/for-4.13-fixes] cgroup: fix error return value from cgroup_subtree_control() Message-ID: <20170723121548.GB1498614@devbig577.frc2.facebook.com> References: <20170723121415.GA1498614@devbig577.frc2.facebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170723121415.GA1498614@devbig577.frc2.facebook.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 23, 2017 at 08:14:15AM -0400, Tejun Heo wrote: > While refactoring, f7b2814bb9b6 ("cgroup: factor out > cgroup_{apply|finalize}_control() from > cgroup_subtree_control_write()") broke error return value from the > function. The return value from the last operation is always > overridden to zero. Fix it. > > Signed-off-by: Tejun Heo > Cc: stable@vger.kernel.org # v4.6+ Applying to cgroup/for-4.13-fixes. Thanks. -- tejun