From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752503AbdGXH6W (ORCPT ); Mon, 24 Jul 2017 03:58:22 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:54474 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752301AbdGXH6L (ORCPT ); Mon, 24 Jul 2017 03:58:11 -0400 Date: Mon, 24 Jul 2017 00:57:55 -0700 From: Christoph Hellwig To: Arnd Bergmann Cc: Trond Myklebust , Anna Schumaker , Benjamin Coddington , Alexey Dobriyan , Jens Axboe , Andrew Morton , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [RESEND] nfs: blocklayout: avoid warnings on 32-bit sector_t Message-ID: <20170724075755.GA8149@infradead.org> References: <20170721201547.3358107-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170721201547.3358107-1-arnd@arndb.de> User-Agent: Mutt/1.8.0 (2017-02-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A 32-bit will also cause run-time problems. I think the block layout code should instead grow a depends on 64BIT || LBDAF to ensure we always have a 64-bit sector_t.