From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755636AbdGXSv3 (ORCPT ); Mon, 24 Jul 2017 14:51:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:56758 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753090AbdGXSvU (ORCPT ); Mon, 24 Jul 2017 14:51:20 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6648122BE9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=sre@kernel.org Date: Mon, 24 Jul 2017 20:51:16 +0200 From: Sebastian Reichel To: Arnd Bergmann Cc: Tony Lindgren , linux-kernel@vger.kernel.org Subject: Re: [PATCH] power: supply: cpcap-charger: add OMAP_USB2 dependency Message-ID: <20170724185116.6dnjyelzf4l37fmk@earth> References: <20170721161511.3334292-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="y62almaove6dd2cf" Content-Disposition: inline In-Reply-To: <20170721161511.3334292-1-arnd@arndb.de> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --y62almaove6dd2cf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Jul 21, 2017 at 06:14:37PM +0200, Arnd Bergmann wrote: > When CONFIG_OMAP_USB2 is set to 'm' and the charger driver is built-in, > we get this link failure: >=20 > drivers/power/supply/cpcap-charger.o: In function `cpcap_charger_probe': > cpcap-charger.c:(.text+0x48c): undefined reference to `omap_usb2_set_comp= arator' > drivers/power/supply/cpcap-charger.o: In function `cpcap_charger_remove': > cpcap-charger.c:(.text+0x774): undefined reference to `omap_usb2_set_comp= arator' >=20 > This adds a dependency to prevent that problem, while still allowing > compile-testing with the OMAP_USB2 driver completely disabled. >=20 > Fixes: 0c9888e3c192 ("power: supply: cpcap-charger: Add minimal CPCAP PMI= C battery charger") > Signed-off-by: Arnd Bergmann > --- Thanks, applied to power-supply's fixes branch. -- Sebastian --y62almaove6dd2cf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAll2QaQACgkQ2O7X88g7 +poosg/+PsJKHtS0zvSmoTVZuWixcWvtkYq1qw3d6eHp9rG17UYOLYwz2iF9MDop wQltrR2HjIx720SFuf6xnmojBc/GTkYUUwd5aKS2MqqMcouE4FMh5TVIrcdP8vHq gv9IqOfcAS6sfqZP52v+SimtzNao2wvmNYUggdaEGD+7Pz5qOZEyELQc8IQ8gdYR jzgmcIMMgi1kmUhdht4iwuqOTYYf7HHse1vSOtij1OldeYbgO9shdsw1g5lOB7lb 5VmbBplT/EfkxHKRjRKGrktq1IVFJABR0adTPfguFBH59BNmbk5NgFk3Uc2Q0T53 b/CknYyEysQ4/RjSA5oh9Gr1fHVQexgbLYvuswZnAm9OaJDotsFflCdF7z/FxCMC 5QTGvWJ/8AWG/Dtu+O/DPdIBJX1pPG35NM2zUX/Pw08FZbBcukPyrPotefpZE4bn TQBh2kE8aTR5068IGUf7XAkJ0tV9M78zWJMd6x4WpC7KHmMFYu4UYTYiiUhu1Cgl xTqPdK0MW0nLCdMNEZ/V190mnhoF+Pc9+elt14kEOUt0bMAhSbYv1g1M89DDSk+N lc2UosOxmIbLWbTbpoajwoFzUCjq47XYbsqmYOIQoPa/q598C5p34gVo+jc42Y44 nXg5G3HmpOYQZhgm23QwoLuFb3P+e0meKunPL/w7cq0xjPcXo9Y= =5lC4 -----END PGP SIGNATURE----- --y62almaove6dd2cf--