From: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
To: Pavel Machek <pavel@ucw.cz>
Cc: Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Tony Lindgren <tony@atomide.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] ARM: dts: omap4-droid4: add soundcard
Date: Tue, 25 Jul 2017 11:08:33 +0200 [thread overview]
Message-ID: <20170725090833.lkqxwk4oakafsmgr@earth> (raw)
In-Reply-To: <20170724191954.GC32425@amd>
[-- Attachment #1: Type: text/plain, Size: 734 bytes --]
Hi,
On Mon, Jul 24, 2017 at 09:19:54PM +0200, Pavel Machek wrote:
> On Mon 2017-07-10 13:26:02, Mark Brown wrote:
> > On Fri, Jul 07, 2017 at 06:42:29PM +0200, Sebastian Reichel wrote:
> >
> > > + soundcard {
> > > + compatible = "simple-audio-card";
> > > + simple-audio-card,name = "Droid 4 Audio";
> >
> > New systems should be using the of-graph card which is more flexible and
> > extensible than simple-card.
>
> Well, if simple-card does what is needed here, and dts looks
> reasonable, is there reason for anything more complex?
There is already a PATCHv2 for this patchset, that switched to
the graph based card.
> Anyway, congratulations for getting the sound to work!
Thanks.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-07-25 9:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-07 16:42 [PATCH 0/3] Motorola Droid 4 Audio Support Sebastian Reichel
2017-07-07 16:42 ` [PATCH 1/3] ASoC: codec: cpcap: new codec Sebastian Reichel
2017-07-09 5:39 ` Tony Lindgren
2017-07-10 15:28 ` Rob Herring
2017-07-10 17:51 ` Mark Brown
2017-07-11 5:15 ` Tony Lindgren
2017-07-11 10:49 ` Mark Brown
2017-07-11 12:13 ` Sebastian Reichel
2017-07-11 13:33 ` Mark Brown
2017-07-07 16:42 ` [PATCH 2/3] ARM: dts: motorola-cpcap-mapphone: add audio-codec Sebastian Reichel
2017-07-07 16:42 ` [PATCH 3/3] ARM: dts: omap4-droid4: add soundcard Sebastian Reichel
2017-07-10 12:26 ` Mark Brown
2017-07-24 19:19 ` Pavel Machek
2017-07-25 9:08 ` Sebastian Reichel [this message]
2017-07-08 5:27 ` [PATCH 0/3] Motorola Droid 4 Audio Support Tony Lindgren
2017-07-08 11:34 ` Sebastian Reichel
2017-07-09 5:33 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170725090833.lkqxwk4oakafsmgr@earth \
--to=sebastian.reichel@collabora.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®