From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755865AbdGYBqH (ORCPT <rfc822;w@1wt.eu>);
        Mon, 24 Jul 2017 21:46:07 -0400
Received: from mail.kernel.org ([198.145.29.99]:39126 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1755306AbdGYBp7 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 24 Jul 2017 21:45:59 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 29F7C22B4E
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=mhiramat@kernel.org
Date: Tue, 25 Jul 2017 10:45:54 +0900
From: Masami Hiramatsu <mhiramat@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        Ingo Molnar <mingo@kernel.org>,
        Francis Deslauriers <francis.deslauriers@efficios.com>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
        Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -tip] [BUGFIX] kprobes/x86: Do not jump-optimize kprobes
 on irq entry code
Message-Id: <20170725104554.b58850228986eb94d56dcb0e@kernel.org>
In-Reply-To: <20170725091529.f278542cb1216ae453709371@kernel.org>
References: <150090423041.5120.14097142754651275640.stgit@devbox>
        <380689532.23393.1500906516467.JavaMail.zimbra@efficios.com>
        <20170725091529.f278542cb1216ae453709371@kernel.org>
X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 25 Jul 2017 09:15:29 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:

> > arch/x86/kernel/unwind_frame.c is only compiled when CONFIG_FRAME_POINTER
> > is enabled, but CONFIG_KPROBES does not depend on it.
> > 
> > Is unwind_frame.c really where in_entry_code() should be implemented, now
> > that its symbol becomes exposed to other compile units ?
> 
> At least kprobes needs it. (as far 
> It seems we can move it in arch/x86/entry/common.c or 
> somewhere in header. (arm has arch/arm/include/asm/traps.h for
> that purpose)

As far as I can see, that code is only for unwinder or kprobes,
and only arm/arm64 has similar code.

I've decided to make this fix kprobe/opt.c local, since this fix
is also needed for stable. I'll send v2 patch soon.

Thanks,

-- 
Masami Hiramatsu <mhiramat@kernel.org>