From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752022AbdGYNgI (ORCPT ); Tue, 25 Jul 2017 09:36:08 -0400 Received: from mx2.suse.de ([195.135.220.15]:55564 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751810AbdGYNgH (ORCPT ); Tue, 25 Jul 2017 09:36:07 -0400 Date: Tue, 25 Jul 2017 15:36:04 +0200 From: Michal Hocko To: Anshuman Khandual Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, mike.kravetz@oracle.com Subject: Re: [PATCH V2] selftests/vm: Add tests to validate mirror functionality with mremap Message-ID: <20170725133604.GA27322@dhcp22.suse.cz> References: <20170725063657.3915-1-khandual@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170725063657.3915-1-khandual@linux.vnet.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 25-07-17 12:06:57, Anshuman Khandual wrote: [...] > diff --git a/tools/testing/selftests/vm/mremap_mirror_private_anon.c b/tools/testing/selftests/vm/mremap_mirror_private_anon.c [...] > + ptr = mmap(NULL, alloc_size, PROT_READ | PROT_WRITE, > + MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); > + if (ptr == MAP_FAILED) { > + perror("map() failed"); > + return -1; > + } > + memset(ptr, PATTERN, alloc_size); > + > + mirror_ptr = (char *) mremap(ptr, 0, alloc_size, MREMAP_MAYMOVE); > + if (mirror_ptr == MAP_FAILED) { > + perror("mremap() failed"); > + return -1; > + } What is the point of this test? It will break with Mike's patch very soon. Btw. it never worked. -- Michal Hocko SUSE Labs