From: Arnd Bergmann <arnd@arndb.de>
To: "David S. Miller" <davem@davemloft.net>,
Michael Chan <michael.chan@broadcom.com>,
Sathya Perla <sathya.perla@broadcom.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Thomas Gleixner <tglx@linutronix.de>,
Edward Cree <ecree@solarflare.com>,
Richard Cochran <richardcochran@gmail.com>,
Nicolas Pitre <nicolas.pitre@linaro.org>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net-next 1/2] bnxt_en: add CONFIG_NET_SWITCHDEV dependency
Date: Tue, 25 Jul 2017 17:29:51 +0200 [thread overview]
Message-ID: <20170725153046.44726-1-arnd@arndb.de> (raw)
Without CONFIG_SWITCHDEV, we run into a compile-time error:
drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c: In function 'bnxt_vf_rep_netdev_init':
drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c:305:7: error: 'struct net_device' has no member named 'switchdev_ops'; did you mean 'netdev_ops'?
This adds a Kconfig dependency to prevent running into this invalid
configuration.
Fixes: c124a62ff2dd ("bnxt_en: add support for port_attr_get and and get_phys_port_name")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/ethernet/broadcom/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig
index 285f8bc25682..095bb816ab48 100644
--- a/drivers/net/ethernet/broadcom/Kconfig
+++ b/drivers/net/ethernet/broadcom/Kconfig
@@ -194,6 +194,7 @@ config BNXT
tristate "Broadcom NetXtreme-C/E support"
depends on PCI
depends on MAY_USE_DEVLINK
+ depends on NET_SWITCHDEV
select FW_LOADER
select LIBCRC32C
---help---
--
2.9.0
next reply other threads:[~2017-07-25 15:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 15:29 Arnd Bergmann [this message]
2017-07-25 15:29 ` [PATCH net-next 2/2] bnxt_en: define sriov_lock unconditionally Arnd Bergmann
2017-07-25 16:36 ` Michael Chan
2017-07-26 9:05 ` Arnd Bergmann
2017-07-26 10:54 ` Sathya Perla
2017-07-26 13:18 ` Arnd Bergmann
2017-07-27 7:48 ` Arnd Bergmann
2017-07-27 9:00 ` Sathya Perla
2017-07-27 9:53 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170725153046.44726-1-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=richardcochran@gmail.com \
--cc=sathya.perla@broadcom.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®