From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753078AbdGYPtG (ORCPT ); Tue, 25 Jul 2017 11:49:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47004 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753059AbdGYPtE (ORCPT ); Tue, 25 Jul 2017 11:49:04 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A122C7EA98 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jpoimboe@redhat.com Date: Tue, 25 Jul 2017 10:49:03 -0500 From: Josh Poimboeuf To: Arnd Bergmann Cc: Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH] objtool: make orc_types.h headers match Message-ID: <20170725154903.22lf6srssd6n36lk@treble> References: <20170725152858.21264-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170725152858.21264-1-arnd@arndb.de> User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 25 Jul 2017 15:49:04 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 25, 2017 at 05:28:48PM +0200, Arnd Bergmann wrote: > Building objtool causes a warning on the latest linux-next kernels: > > warning: objtool: orc_types.h differs from kernel > > From what I can tell, we have two slightly different copies of the same > header, and we try to ensure they are the same with the warning. Oops! > This picks the copy from the x86 headers (without the __packed > annotation), by roll of dice. You lost ;-) It should be __packed. BTW this will also be fixed when the ORC unwinder gets merged, which will presumably be soon. > Fixes: 39358a033b2e ("objtool, x86: Add facility for asm code to provide unwind hints") ^^^ This is the one that introduced the bug. -- Josh