From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751797AbdGZPPs (ORCPT ); Wed, 26 Jul 2017 11:15:48 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:59155 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751543AbdGZPPq (ORCPT ); Wed, 26 Jul 2017 11:15:46 -0400 From: Arnd Bergmann To: netdev@vger.kernel.org, Kishon Vijay Abraham I , "David S . Miller" Cc: Andrew Lunn , Florian Fainelli , linux-kernel@vger.kernel.org, Raviteja Garimella , Arnd Bergmann , =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= Subject: [PATCH 2/2] phy: bcm-ns-usb3: fix MDIO_BUS dependency Date: Wed, 26 Jul 2017 17:14:00 +0200 Message-Id: <20170726151442.3913622-2-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170726151442.3913622-1-arnd@arndb.de> References: <20170726151442.3913622-1-arnd@arndb.de> X-Provags-ID: V03:K0:AF0HanJqhPmxgtU1q0wbwVcfw7x95ZNRHR3DUrVcix8bxLxTazF j0F2I6pY9lDOS3QOkJkGrxP5V0OFS8NDSfSziyj7Zn3EqBU7/Rvo9Tu06PMchiqWUqbYWfl lieBxy3qEVGaKPsBFwmvTYVbzKAPMpj0AsT5DBiMfFlyxs8HL9EyQ0I1spKD1bBAjNark3+ Qs68DMWKTUawB6sf4k6kw== X-UI-Out-Filterresults: notjunk:1;V01:K0:dK3T983+Cfk=:OmUctFzS37bW3Q74rlj8+c i+2qvbdq23+Esd2kOL4BOC97EkYyhatfPK6soZp/7GhanMlrnor4xbbJNmbr3ZR2vgmhcSAab tgIdFd3fFZ3EFdc17JBZcO5eJhIWXtTZvDECXn+O9fCcYhNKiAT2g651ZtwrqPWe6srnJA8Tx hvMWsa7EHGmIPTMu+ofV1ogQyalriLG9exWVq0MFUbthDF0c5wqFajufIVNxd/KKQhX5umoep PzaZnQE6HCDRcXxm/FLRUMWEWyRWjfIB2ybKV7LI/UDV5BUd8Xqq5wQWWK+9FB0DXjdT57Z1j fA05hQLh0LYJ2NRmJHJ1QgllE1DbFhsTP9OSYh3JT6Ln8emnCxBtJ9RWhKDHmgcWLftuxMtwp 4KgfG7UYt0b/l0rBdVBE2xmSiFkdNPyUFeTEuV1A/dsiumjSz8oFUn9Sh8J6uIYxvSpD08kl6 a+eYb3yx/ritA+SvjgiN6LpLbnXgv34DBtZKIwsic+2JVj7ZiERIhDWA3cPvjuZ8jqxdBTuaw HDLKoo4M6+guf8lKWL80JJ21geWzkpABNLLJgJq2pqg4ClWv1qmPDvMv3jcqDJhQ54xbW4Qnu w/IXf6RLoOj00Hx+ZU7UH2r8IhbigGsPkOeWQAYCJK6ijwEntl8g4nFCH8VfQrZ1hHGJWQHWQ 4VqEV0UzAeQTx2nzSU7IjpNzVbN24Uihn7eQSlMBQqdZt0ZsQPBouiHl8KPufof6l09XMy1Xi SKArjLXLcv187hGpeEh85nQ51Z4yWREPN7Aseg== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver attempts to 'select MDIO_DEVICE', but the code is actually a loadable module when PHYLIB=m: drivers/phy/broadcom/phy-bcm-ns-usb3.o: In function `bcm_ns_usb3_mdiodev_phy_write': phy-bcm-ns-usb3.c:(.text.bcm_ns_usb3_mdiodev_phy_write+0x28): undefined reference to `mdiobus_write' drivers/phy/broadcom/phy-bcm-ns-usb3.o: In function `bcm_ns_usb3_module_exit': phy-bcm-ns-usb3.c:(.exit.text+0x18): undefined reference to `mdio_driver_unregister' drivers/phy/broadcom/phy-bcm-ns-usb3.o: In function `bcm_ns_usb3_module_init': phy-bcm-ns-usb3.c:(.init.text+0x18): undefined reference to `mdio_driver_register' phy-bcm-ns-usb3.c:(.init.text+0x38): undefined reference to `mdio_driver_unregister' Using 'depends on MDIO_BUS' instead will avoid the link error. Fixes: af850e14a7ae ("phy: bcm-ns-usb3: add MDIO driver using proper bus layer") Signed-off-by: Arnd Bergmann Reviewed-by: Florian Fainelli --- drivers/phy/broadcom/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/broadcom/Kconfig b/drivers/phy/broadcom/Kconfig index 37371b89b14f..64fc59c3ae6d 100644 --- a/drivers/phy/broadcom/Kconfig +++ b/drivers/phy/broadcom/Kconfig @@ -30,8 +30,8 @@ config PHY_BCM_NS_USB3 tristate "Broadcom Northstar USB 3.0 PHY Driver" depends on ARCH_BCM_IPROC || COMPILE_TEST depends on HAS_IOMEM && OF + depends on MDIO_BUS select GENERIC_PHY - select MDIO_DEVICE help Enable this to support Broadcom USB 3.0 PHY connected to the USB controller on Northstar family. -- 2.9.0